build: exclude tap files from tarballs - #6348
Merged
mscdex merged 1 commit intoApr 28, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mscdex
force-pushed
the
build-exclude-tap-from-tarballs
branch
from
6e97c92 to
389edbd
Compare
April 22, 2016 14:26
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
How about *.tap? Regardless LGTM. Edit: rationale being we might have lint.tap, etc. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
lgtm |
Sorry, something went wrong.
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
7da4fd4 to
c7066fb
Compare
April 26, 2016 05:23
PR-URL: nodejs#6348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
mscdex
force-pushed
the
build-exclude-tap-from-tarballs
branch
from
389edbd to
be54989
Compare
April 28, 2016 15:28
Fishrock123
pushed a commit
that referenced
this pull request
May 4, 2016
PR-URL: #6348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced May 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
This commit excludes generated tap files from tarballs.