stream: keep overlapping broadcast reads pending - #63500
Merged
nodejs-github-bot merged 1 commit intoJun 20, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #63500 +/- ##
=======================================
Coverage 90.34% 90.35%
=======================================
Files 732 732
Lines 236689 236741 +52
Branches 44586 44601 +15
=======================================
+ Hits 213839 213897 +58
Misses 14550 14550
+ Partials 8300 8294 -6
... and 25 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
approved these changes
May 23, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
force-pushed
the
stream-iter-broadcast-next-pending
branch
from
87668cb to
ae779b6
Compare
May 25, 2026 22:22
trivikr
force-pushed
the
stream-iter-broadcast-next-pending
branch
from
ae779b6 to
c556978
Compare
May 25, 2026 22:24
Copy link
Copy Markdown
Member
Author
|
Requested a re-review, as the previous fix incorrectly resolved the second next() while it should have been kept pending. It's now fixed in amended commit. Details in #63499 (comment) |
Sorry, something went wrong.
trivikr
force-pushed
the
stream-iter-broadcast-next-pending
branch
from
c556978 to
c47708d
Compare
May 27, 2026 01:21
trivikr
force-pushed
the
stream-iter-broadcast-next-pending
branch
3 times, most recently
from
f1aaff6 to
d2bf99e
Compare
June 2, 2026 03:43
trivikr
force-pushed
the
stream-iter-broadcast-next-pending
branch
3 times, most recently
from
af686c7 to
1ac85e8
Compare
June 13, 2026 14:06
trivikr
force-pushed
the
stream-iter-broadcast-next-pending
branch
from
1ac85e8 to
e35fded
Compare
June 15, 2026 03:53
Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
stream-iter-broadcast-next-pending
branch
from
e35fded to
8a996e3
Compare
June 18, 2026 00:24
jasnell
approved these changes
Jun 19, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jun 20, 2026
Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500 Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: nodejs#63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63500 Fixes: nodejs#63499 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Broadcast consumers may receive overlapping next() calls on the same iterator. Queue those reads so chunks satisfy them in call order. A single written chunk should resolve the earliest pending next(); later next() calls remain pending until more data is written or the broadcast completes. Fixes: #63499 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63500 Backport-PR-URL: #64675 Fixes: #63499 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broadcast() consumers could leave an earlier next() call pending forever
when another next() was called before data became available. The later call
overwrote the stored resolver, so the next write resolved the newer promise
instead of the older one.
This updates broadcast consumers to keep the first pending read intact. A
later overlapping next() now closes that consumer, while the original pending
read still receives the next chunk.
Fixes: #63499
Assisted-by: openai:gpt-5.5