tools: add lint rule for aborted AbortController - #63541
Merged
nodejs-github-bot merged 5 commits intoMay 28, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #63541 +/- ##
==========================================
+ Coverage 90.29% 90.31% +0.02%
==========================================
Files 730 730
Lines 234695 234695
Branches 43956 43955 -1
==========================================
+ Hits 211927 211974 +47
+ Misses 14494 14436 -58
- Partials 8274 8285 +11 see 48 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
trivikr
force-pushed
the
eslint-abort-signal-abort
branch
from
55470dd to
2cd59c6
Compare
May 25, 2026 01:44
metcoder95
approved these changes
May 25, 2026
aduh95
reviewed
May 25, 2026
Comment thread
test/parallel/test-abortcontroller.js
Outdated
Comment thread
test/parallel/test-eslint-prefer-abort-signal-abort.js
Outdated
Comment thread
test/parallel/test-eslint-prefer-abort-signal-abort.js
Outdated
Comment thread
tools/eslint-rules/prefer-abort-signal-abort.js
Outdated
Ethan-Arrowood
approved these changes
May 27, 2026
This comment was marked as outdated.
aduh95
approved these changes
May 27, 2026
Refs: nodejs#63489 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Assisted-by: openai:gpt-5.5
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
trivikr
force-pushed
the
eslint-abort-signal-abort
branch
from
be4a7ca to
a506493
Compare
May 28, 2026 00:17
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This comment was marked as outdated.
Qard
approved these changes
May 28, 2026
aduh95
added a commit
that referenced
this pull request
May 30, 2026
Refs: #63489 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Assisted-by: openai:gpt-5.5 PR-URL: #63541 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
added a commit
that referenced
this pull request
May 30, 2026
Refs: #63489 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Assisted-by: openai:gpt-5.5 PR-URL: #63541 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
added a commit
that referenced
this pull request
Aug 6, 2026
Refs: #63489 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Assisted-by: openai:gpt-5.5 PR-URL: #63541 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an ESLint rule to prefer AbortSignal.abort() when a test creates an
AbortController, immediately aborts it, and only uses the resulting
controller.signal.
The rule is intentionally conservative and only fixes the simple already-aborted
signal pattern from #63489.
The rule uses ESLint scope analysis rather than text matching. After finding a
candidate declaration, it gets the declared variable with
sourceCode.scopeManager.getDeclaredVariables() and checks all references to
that variable.
It only reports when the variable has exactly two non-declaration references:
If the controller is logged, passed somewhere else, aborted later, read more than
once, or otherwise referenced, the rule does not report or autofix it.
Assisted-by: openai:gpt-5.5