stream: handle sync writev completion in pipeTo - #63561
Merged
nodejs-github-bot merged 1 commit intoJun 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Treat writer.writev() returning undefined as synchronous success to match the existing write() fallback behavior for duck-typed writers. This avoids calling Promise.prototype.then on undefined after a batch write has already been accepted. Fixes: nodejs#63560 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
stream-iter-sync-writev-undefined
branch
from
13ee76d to
825d2c9
Compare
May 25, 2026 16:51
jasnell
approved these changes
May 25, 2026
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #63561 +/- ##
==========================================
- Coverage 90.33% 90.32% -0.02%
==========================================
Files 730 730
Lines 234362 234472 +110
Branches 43906 43916 +10
==========================================
+ Hits 211713 211781 +68
- Misses 14371 14433 +62
+ Partials 8278 8258 -20
... and 43 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
Treat writer.writev() returning undefined as synchronous success to match the existing write() fallback behavior for duck-typed writers. This avoids calling Promise.prototype.then on undefined after a batch write has already been accepted. Fixes: #63560 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63561 Fixes: #63560 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Treat writer.writev() returning undefined as synchronous success to match the existing write() fallback behavior for duck-typed writers. This avoids calling Promise.prototype.then on undefined after a batch write has already been accepted. Fixes: nodejs#63560 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63561 Fixes: nodejs#63560 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Treat writer.writev() returning undefined as synchronous success to match the existing write() fallback behavior for duck-typed writers. This avoids calling Promise.prototype.then on undefined after a batch write has already been accepted. Fixes: #63560 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63561 Backport-PR-URL: #64675 Fixes: #63560 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63560
Fixes stream/iter pipeTo() when a duck-typed writer accepts a batched
writev() synchronously and returns undefined.
pipeTo() already tolerated undefined from single write() calls, but the
writev() path passed the return value directly to PromisePrototypeThen(),
which caused a TypeError for synchronous completion.
Assisted-by: openai:gpt-5.5