stream: fix pipeToSync byte accounting - #63564
Merged
nodejs-github-bot merged 1 commit intoJun 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
trivikr
force-pushed
the
stream-iter-pipetosync-writesync-backpressure
branch
from
0b933ff to
8b50431
Compare
May 25, 2026 16:54
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #63564 +/- ##
========================================
Coverage 90.33% 90.33%
========================================
Files 730 730
Lines 234362 234487 +125
Branches 43906 43932 +26
========================================
+ Hits 211713 211835 +122
- Misses 14371 14389 +18
+ Partials 8278 8263 -15
... and 43 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
trivikr
marked this pull request as draft
May 25, 2026 23:01
This comment was marked as outdated.
trivikr
marked this pull request as ready for review
June 8, 2026 01:49
trivikr
force-pushed
the
stream-iter-pipetosync-writesync-backpressure
branch
from
8b50431 to
7daf002
Compare
June 8, 2026 01:49
Stop pipeToSync() from counting chunks when writeSync() or writevSync() returns false without accepting the data. Preserve writers that use false as an accepted backpressure signal. Fixes: nodejs#63562 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
stream-iter-pipetosync-writesync-backpressure
branch
from
7daf002 to
70cf4f8
Compare
June 8, 2026 02:06
mcollina
approved these changes
Jun 8, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
Stop pipeToSync() from counting chunks when writeSync() or writevSync() returns false without accepting the data. Preserve writers that use false as an accepted backpressure signal. Fixes: #63562 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63564 Fixes: #63562 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Stop pipeToSync() from counting chunks when writeSync() or writevSync() returns false without accepting the data. Preserve writers that use false as an accepted backpressure signal. Fixes: nodejs#63562 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63564 Fixes: nodejs#63562 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Stop pipeToSync() from counting chunks when writeSync() or writevSync() returns false without accepting the data. Preserve writers that use false as an accepted backpressure signal. Fixes: #63562 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63564 Backport-PR-URL: #64675 Fixes: #63562 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63562
pipeToSync() ignored explicit false returns from writeSync() and
writevSync(), so it could report bytes for chunks that were not accepted by
the writer.
This updates pipeToSync() to stop counting rejected sync writes while still
preserving writers that intentionally return false after accepting data as a
backpressure signal.
Assisted-by: openai:gpt-5.5