stream: handle falsy push writer fail reasons - #63569
Merged
nodejs-github-bot merged 1 commit intoJun 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #63569 +/- ##
==========================================
- Coverage 91.95% 90.33% -1.63%
==========================================
Files 379 732 +353
Lines 166486 236459 +69973
Branches 25452 44534 +19082
==========================================
+ Hits 153099 213610 +60511
- Misses 13094 14548 +1454
- Partials 293 8301 +8008
... and 478 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
trivikr
force-pushed
the
stream-iter-writer-fail-pending
branch
2 times, most recently
from
047dd35 to
cf08dca
Compare
May 27, 2026 15:37
Reject reads based on writer state so explicit falsy fail reasons do not leave reads pending. Fixes: nodejs#63568 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
stream-iter-writer-fail-pending
branch
from
cf08dca to
bdda946
Compare
May 31, 2026 05:25
mcollina
approved these changes
May 31, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Reject reads based on writer state so explicit falsy fail reasons do not leave reads pending. Fixes: nodejs#63568 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63569 Fixes: nodejs#63568 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Reject reads based on writer state so explicit falsy fail reasons do not leave reads pending. Fixes: #63568 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63569 Backport-PR-URL: #64675 Fixes: #63568 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes stream/iter push writer reads after writer.fail() is called
with an explicit falsy reason.
Reads now use the writer state instead of the truthiness of the stored error,
so reasons like 0 and false reject correctly instead of leaving reads
pending.
Fixes: #63568
Assisted-by: openai:gpt-5.5