FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: merge `CreateEnvironment()` overloads by addaleax · Pull Request #63596 · nodejs/node · GitHub

/ node Public

src: merge CreateEnvironment() overloads - #63596

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:abi-break-CreateEnvironment
Jun 4, 2026
ConversationCommits (1)ChecksFiles changed
Merged

src: merge CreateEnvironment() overloads#63596
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:abi-break-CreateEnvironment

Conversation

addaleax commented May 27, 2026

Copy link
Copy Markdown
Member

API-compatible, but ABI-breaking, so done separately from the original 3090def.

addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version. labels May 27, 2026
nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 27, 2026
addaleax force-pushed the abi-break-CreateEnvironment branch from 23c5506 to 37016f3 Compare May 27, 2026 09:04
addaleax changed the title src: merge CreateEnvironment() implementations src: merge CreateEnvironment() overloads May 27, 2026

codecov Bot commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (8257091) to head (a21167c).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #63596   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files         730      730           
  Lines      234671   234662    -9     
  Branches    43946    43958   +12     
=======================================
+ Hits       211965   211967    +2     
  Misses      14423    14423           
+ Partials     8283     8272   -11
Files with missing lines Coverage Δ
src/api/environment.cc 78.72% <ø> (-0.30%) ⬇️
src/node.h 92.30% <ø> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin approved these changes May 27, 2026
View reviewed changes

mertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

legendecas commented May 27, 2026

Copy link
Copy Markdown
Member

The linter error should be fixed with #63598 landed on the main branch. Would you mind rebasing on top of the main branch?

src: merge CreateEnvironment() overloads
a21167c 
API-compatible, but ABI-breaking, so done separately from the
original 3090def.

Signed-off-by: Anna Henningsen <anna@addaleax.net>

addaleax commented May 27, 2026

Copy link
Copy Markdown
Member Author

@legendecas Thank you, done!

addaleax force-pushed the abi-break-CreateEnvironment branch from 37016f3 to a21167c Compare May 27, 2026 19:20
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2026

nodejs-github-bot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73795/

nodejs-github-bot commented May 28, 2026 •
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73803/ (💚)

addaleax commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

@nodejs/tsc This is technically semver-major because of the ABI change so needs another TSC approval

gurgunday approved these changes Jun 3, 2026
View reviewed changes

gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

gurgunday added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 3, 2026
addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2026
nodejs-github-bot merged commit 2d0c926 into nodejs:main Jun 4, 2026
77 checks passed

nodejs-github-bot commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Landed in 2d0c926

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
legendecas legendecas approved these changes
gurgunday gurgunday approved these changes
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL