stream: settle pending broadcast reads on return - #63603
Merged
nodejs-github-bot merged 1 commit intoMay 31, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Resolve pending next() calls when broadcast consumers are returned, so the promise does not remain pending after iterator cleanup. Fixes: nodejs#63519 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #63603 +/- ##
==========================================
+ Coverage 90.29% 90.31% +0.02%
==========================================
Files 730 730
Lines 234695 234696 +1
Branches 43956 43954 -2
==========================================
+ Hits 211927 211976 +49
+ Misses 14494 14431 -63
- Partials 8274 8289 +15
... and 48 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Ethan-Arrowood
approved these changes
May 28, 2026
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
May 31, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
Resolve pending next() calls when broadcast consumers are returned, so the promise does not remain pending after iterator cleanup. Fixes: #63519 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63603 Fixes: #63519 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Resolve pending next() calls when broadcast consumers are returned, so the promise does not remain pending after iterator cleanup. Fixes: nodejs#63519 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63603 Fixes: nodejs#63519 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Resolve pending next() calls when broadcast consumers are returned, so the promise does not remain pending after iterator cleanup. Fixes: #63519 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63603 Backport-PR-URL: #64675 Fixes: #63519 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates broadcast async iterator cleanup so a pending
next() settles when the consumer is returned.
When a broadcast consumer has an outstanding next() and
return() is called before data arrives, the pending read is now
resolved with { done: true, value: undefined } during detach.
Fixes: #63519
Assisted-by: openai:gpt-5.5