crypto: runtime-deprecate calling Hmac.digest() more than once - #63624
Merged
nodejs-github-bot merged 1 commit intoJun 15, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This was referenced Jun 15, 2026
Emit a DEP0206 deprecation warning when Hmac.digest() is called on an already-finalized instance. This behavior is inconsistent with Hash.digest() which throws ERR_CRYPTO_HASH_FINALIZED. Fixes: nodejs#62838 Co-authored-by: Filip Skokan <panva.ip@gmail.com> Signed-off-by: developers-universe-1 <madelynreyes2026@gmail.com> Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
force-pushed
the
dep0206-hmac-digest-runtime-deprecation
branch
from
59c5a36 to
707d1dd
Compare
June 15, 2026 07:47
panva
approved these changes
Jun 15, 2026
AugustinMauroy
approved these changes
Jun 15, 2026
Copy link
Copy Markdown
Member
|
cc @nodejs/tsc for semver-major PRs that contain breaking changes and should be released in the next major version. |
Sorry, something went wrong.
anonrig
approved these changes
Jun 15, 2026
This comment was marked as outdated.
gurgunday
approved these changes
Jun 15, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit a DEP0206 deprecation warning when Hmac.digest() is called on an already-finalized instance. This behavior is inconsistent with Hash.digest() which throws ERR_CRYPTO_HASH_FINALIZED.
Fixes: #62838