FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: remove old alias usage in ffi benchmarks by addaleax · Pull Request #63666 · nodejs/node · GitHub

/ node Public

benchmark: remove old alias usage in ffi benchmarks - #63666

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
addaleax:ffi-benchmark-fix
Jun 1, 2026
ConversationCommits (2)ChecksFiles changed
Merged

benchmark: remove old alias usage in ffi benchmarks#63666
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
addaleax:ffi-benchmark-fix

Conversation

addaleax commented May 30, 2026

Copy link
Copy Markdown
Member

Follow-up to df09b2a.

Refs: #63482

benchmark: remove old alias usage in ffi benchmarks
2a4bb29 
Follow-up to df09b2a.

Refs: nodejs#63482
Signed-off-by: Anna Henningsen <anna@addaleax.net>

nodejs-github-bot commented May 30, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance

addaleax added benchmark Issues and PRs related to the benchmark subsystem. ffi Issues and PRs related to experimental Foreign Function Interface support. labels May 30, 2026
mertcanaltin reviewed May 30, 2026
View reviewed changes
Comment thread benchmark/ffi/add-f64.js Outdated
mertcanaltin reviewed May 30, 2026
View reviewed changes
Comment thread benchmark/ffi/getpid.js Outdated
Comment thread benchmark/ffi/many-args.js Outdated
Comment thread benchmark/ffi/pointer-bigint.js Outdated
Comment thread benchmark/ffi/sum-buffer.js Outdated
addaleax commented May 31, 2026
View reviewed changes
Comment thread benchmark/ffi/add-i32.js Outdated
fixup! benchmark: remove old alias usage in ffi benchmarks
1fbe68f 
Co-authored-by: Mert Can Altin <mertgold60@gmail.com>
Co-authored-by: Anna Henningsen <github@addaleax.net>
H4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 1, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2026
nodejs-github-bot merged commit 7af433b into nodejs:main Jun 1, 2026
38 checks passed

nodejs-github-bot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Landed in 7af433b

aduh95 pushed a commit that referenced this pull request Jun 18, 2026
benchmark: remove old alias usage in ffi benchmarks
066fff1 
Follow-up to df09b2a.

Refs: #63482
Signed-off-by: Anna Henningsen <anna@addaleax.net>
PR-URL: #63666
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
github-actions Bot mentioned this pull request Jun 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
lpinca lpinca approved these changes
H4ad H4ad approved these changes
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. ffi Issues and PRs related to experimental Foreign Function Interface support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL