Revert "handle_wrap: IsRefed -> Unrefed, no isAlive check" - #6382
Closed
Fishrock123 wants to merge 1 commit into
Closed
Revert "handle_wrap: IsRefed -> Unrefed, no isAlive check"#6382Fishrock123 wants to merge 1 commit into
Fishrock123 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This reverts commit 9bb5a5e.
Closed
Copy link
Copy Markdown
Member
|
Were there two that needed to be reverted? Or does this PR revert both? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
No, this reverts only one. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@jasnell I'd like to leave time for @trevnorris to investigate, since he originally thought the patch would be ok. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
yep. we've got time. I'll be rebasing several times off master and will be looking to cut the actual release tomorrow morning around 10:00am pacific. |
Sorry, something went wrong.
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
7da4fd4 to
c7066fb
Compare
April 26, 2016 05:23
Copy link
Copy Markdown
Member
|
@Fishrock123 @trevnorris .. what is the status on this and the other one that would need to be reverted? |
Sorry, something went wrong.
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Apr 26, 2016
This reverts commit 9bb5a5e. Refs: nodejs#6382 Refs: nodejs#6204 Refs: nodejs#5834
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Apr 26, 2016
This reverts commit f938ef7. Refs: nodejs#6382 Refs: nodejs#6204 Refs: nodejs#5834
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Apr 26, 2016
This reverts commit 7d8882b. Refs: nodejs#6382 Refs: nodejs#6204 Refs: nodejs#5834
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
May 3, 2016
This reverts commit 9bb5a5e. Refs: nodejs#6395 Refs: nodejs#6204 Refs: nodejs#6401 Refs: nodejs#6382 Fixes: nodejs#6381 Conflicts: src/handle_wrap.cc test/parallel/test-handle-wrap-isrefed-tty.js test/parallel/test-handle-wrap-isrefed.js
3 tasks
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
May 11, 2016
This reverts commit 9bb5a5e. This API is not suitable because it depended on being able to potentially access the handle's flag after the handle was already cleaned up. Since this is not actually possible (obviously, oops) this newer API no longer makes much sense, and the older API is more suitable. API comparison: IsRefed -> Has a strong reference AND is alive. (Deterministic) Unrefed -> Has a weak reference OR is dead. (Less deterministic) Refs: nodejs#6395 Refs: nodejs#6204 Refs: nodejs#6401 Refs: nodejs#6382 Fixes: nodejs#6381 PR-URL: nodejs#6546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Conflicts: src/handle_wrap.cc test/parallel/test-handle-wrap-isrefed-tty.js test/parallel/test-handle-wrap-isrefed.js
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
May 11, 2016
Rename slightly to HasRef() at bnoordhuis’ request. Better reflects what we actually do for this check. Refs: nodejs#6395 Refs: nodejs#6204 Refs: nodejs#6401 Refs: nodejs#6382 Refs: nodejs#6381 PR-URL: nodejs#6546 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
This reverts commit 9bb5a5e. This API is not suitable because it depended on being able to potentially access the handle's flag after the handle was already cleaned up. Since this is not actually possible (obviously, oops) this newer API no longer makes much sense, and the older API is more suitable. API comparison: IsRefed -> Has a strong reference AND is alive. (Deterministic) Unrefed -> Has a weak reference OR is dead. (Less deterministic) Refs: #6395 Refs: #6204 Refs: #6401 Refs: #6382 Fixes: #6381 PR-URL: #6546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Conflicts: src/handle_wrap.cc test/parallel/test-handle-wrap-isrefed-tty.js test/parallel/test-handle-wrap-isrefed.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
original PR: #6204
subsystem: OOPS
this may be necessary... looks like getting the flags isn't possible if the flag isn't alive because that's literally a nullptr check..
static inline bool IsAlive(const HandleWrap* wrap) { return wrap != nullptr && wrap->GetHandle() != nullptr; }cc @trevnorris I guess