FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

quic: Fix wake up blob by martenrichter · Pull Request #64044 · nodejs/node · GitHub

/ node Public

quic: Fix wake up blob - #64044

Merged
nodejs-github-bot merged 7 commits into
nodejs:mainfrom
martenrichter:wakeupfix
Aug 15, 2026
ConversationCommits (7)ChecksFiles changed
Merged

quic: Fix wake up blob#64044
nodejs-github-bot merged 7 commits into
nodejs:mainfrom
martenrichter:wakeupfix

Conversation

martenrichter commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

The quic implementation calls setWakeUp of Blob with the assumption that it is only executed once per event loop cycle.
This assumption is wrong.
Only setImmediate will guarantee that the
execution is delayed to later in the event loop
and happening once in the event loop.

Fixes: #64035

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 21, 2026

martenrichter commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

@jasnell @pimterry : The issue came up in a call of createBlobReaderIterable.
For the second path, I am not sure if other changes may be more appropriate.

jasnell reviewed Jul 5, 2026
View reviewed changes
Comment thread lib/internal/blob.js Outdated
jasnell reviewed Jul 5, 2026
View reviewed changes
Comment thread lib/internal/blob.js Outdated

martenrichter commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

I have just rebased it.

codecov Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (9024119) to head (4657936).
⚠️ Report is 342 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/blob.js 6.66% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64044      +/-   ##
==========================================
- Coverage   90.15%   90.13%   -0.02%     
==========================================
  Files         743      744       +1     
  Lines      242407   242529     +122     
  Branches    45645    45691      +46     
==========================================
+ Hits       218532   218611      +79     
- Misses      15357    15402      +45     
+ Partials     8518     8516       -2
Files with missing lines Coverage Δ
lib/internal/blob.js 88.51% <6.66%> (-1.35%) ⬇️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

martenrichter and others added 6 commits July 26, 2026 22:19
quic: fix wake up blob
4ee564b 
The quic implementation calls setWakeUp with
the assumption, that it is only executed once
per event loop cycle.
This assumption is wrong.
Only setImmediate will guarantee, that the
execution is delayed to later in the event loop
and happening once in the event loop.

Fixes: nodejs#64035
Signed-off-by: Marten Richter <marten.richter@freenet.de>
quic: Update lib/internal/blob.js more elegantly
fde3d86 
Co-authored-by: James M Snell <jasnell@gmail.com>
quic: fix lib/internal/blob.js
4627799
quic: Apply suggestion from @jasnell for changing setImmediate
6b631e3 
Co-authored-by: James M Snell <jasnell@gmail.com>
quic: fix weakly weakup assignment
04a8c62
quic: fix fin handling, so it is broken
fff623f

martenrichter commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

I have just added something, which is only relevant, if the fin is relevant, see:
#64767

jasnell added quic Issues and PRs related to the QUIC implementation / HTTP/3. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 8, 2026

This comment was marked as outdated.

Sign in to view
jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 8, 2026

nodejs-github-bot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75662/

jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2026
nodejs-github-bot merged commit 9ad097b into nodejs:main Aug 15, 2026
78 checks passed

nodejs-github-bot commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Landed in 9ad097b

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2026
trivenay mentioned this pull request Aug 16, 2026
Open
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
quic: fix wake up blob
efb51b5 
The quic implementation calls setWakeUp with
the assumption, that it is only executed once
per event loop cycle.
This assumption is wrong.
Only setImmediate will guarantee, that the
execution is delayed to later in the event loop
and happening once in the event loop.

Fixes: #64035
Signed-off-by: Marten Richter <marten.richter@freenet.de>
PR-URL: #64044
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
quic: fix wake up blob
009e376 
The quic implementation calls setWakeUp with
the assumption, that it is only executed once
per event loop cycle.
This assumption is wrong.
Only setImmediate will guarantee, that the
execution is delayed to later in the event loop
and happening once in the event loop.

Fixes: #64035
Signed-off-by: Marten Richter <marten.richter@freenet.de>
PR-URL: #64044
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
efekrskl efekrskl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

quic: Accumulation buffer is not filled, if small packets arrive

4 participants

Back | FazBrowse Home | New Git URL