FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "build, doc: generate node.1 with doc-kit" by aduh95 · Pull Request #64091 · nodejs/node · GitHub

/ node Public

Revert "build, doc: generate node.1 with doc-kit" - #64091

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:revert-node.1-doc-kit
Jun 23, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Revert "build, doc: generate node.1 with doc-kit"#64091
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:revert-node.1-doc-kit

Conversation

aduh95 commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This reverts #62044 as that introduced a dependency on running npm to be able to build node.

I ran the following to produce this PR:

make out/doc/node.1 
git revert --no-edit --no-gpg-sign 81e93dff3b4b1d2bea76cb70855f449e38de49fe
mv out/doc/node.1 doc/.
git add doc
git commit --amend -s --no-edit

Ideally we'd want a linter to ensure node.1 stays up-to-date, but this can come in a follow-up.

Revert "build, doc: generate node.1 with doc-kit"
f5762e1 
This reverts commit 81e93df.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/config
  • @nodejs/tsc

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 23, 2026
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 23, 2026
sxa approved these changes Jun 23, 2026
View reviewed changes

sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approving on the basis that this is a straight revert.

mcollina approved these changes Jun 23, 2026
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2026

nodejs-github-bot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74380/

richardlau mentioned this pull request Jun 23, 2026
Merged

nodejs-github-bot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74382/

aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 23, 2026

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2026
nodejs-github-bot merged commit 68f14c2 into nodejs:main Jun 23, 2026
85 checks passed

nodejs-github-bot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Landed in 68f14c2

aduh95 deleted the revert-node.1-doc-kit branch June 23, 2026 20:19
aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jun 23, 2026
aduh95 added a commit that referenced this pull request Jun 23, 2026
Revert "build, doc: generate node.1 with doc-kit"
2a467a5 
This reverts commit 81e93df.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #64091
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
aduh95 mentioned this pull request Jun 23, 2026
Merged
richardlau mentioned this pull request Jun 26, 2026
Merged
richardlau mentioned this pull request Jul 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
panva panva approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes
sxa sxa approved these changes
marco-ippolito marco-ippolito approved these changes
avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL