quic: fix crash when no onstream handler is set with unistream - #64158
Merged
nodejs-github-bot merged 5 commits intoJul 7, 2026
Merged
quic: fix crash when no onstream handler is set with unistream#64158nodejs-github-bot merged 5 commits into
nodejs-github-bot merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Efe Karasakal <hi@efe.dev>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
pimterry
approved these changes
Jun 30, 2026
pimterry
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Some linting errors here but otherwise LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Just fixed them, thanks! |
Sorry, something went wrong.
jasnell
approved these changes
Jul 4, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Qard
approved these changes
Jul 5, 2026
jasnell
reviewed
Jul 5, 2026
Comment thread
test/parallel/test-quic-stream-uni-no-onstream.mjs
Outdated
Signed-off-by: Efe Karasakal <hi@efe.dev>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
pimterry
approved these changes
Jul 7, 2026
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev> PR-URL: #64158 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev> PR-URL: #64158 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev> PR-URL: #64158 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as a fix for #64030 (unidirectional stream crashing when there's no onstream handler). Which was caused by JS synchronously destroying the stream (because there was no handler) and native code still trying to access it.
While testing that, I also ran into teardown issues around destroy() in the same repro. I ended up including this one too, because without it I couldn't test cleanly. Session::Impl::~Impl() could drop the last owner of the Session, then keep using session_->env() afterward. I changed the order so anything that still needs env() runs before the session can disappear.