FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix EventEmitter#eventNames() example by ChALkeR · Pull Request #6417 · nodejs/node · GitHub

/ node Public

doc: fix EventEmitter#eventNames() example - #6417

Closed
ChALkeR wants to merge 1 commit into
nodejs:masterfrom
ChALkeR:fix-events-doc-mistype
ConversationCommits (1)ChecksFiles changed
Closed

doc: fix EventEmitter#eventNames() example#6417
ChALkeR wants to merge 1 commit into
nodejs:masterfrom
ChALkeR:fix-events-doc-mistype

Conversation

ChALkeR commented Apr 27, 2016 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Replace myErr with myEE in one place (that was obviously a mistype).
Fix the expected output to have the actual formatting.

This was overlooked in #5617 (I also didn't notice that).

/cc @jasnell

ChALkeR added the doc Issues and PRs related to the documentations. label Apr 27, 2016
ChALkeR mentioned this pull request Apr 27, 2016
Closed

bnoordhuis commented Apr 27, 2016

Copy link
Copy Markdown
Member

LGTM but you need to s/Fix EventEmmiter/fix EventEmitter/ in the commit log.

ChALkeR force-pushed the fix-events-doc-mistype branch from 7afa3c0 to 57988da Compare April 27, 2016 10:13

ChALkeR commented Apr 27, 2016

Copy link
Copy Markdown
Member Author

@bnoordhuis Done.

ChALkeR force-pushed the fix-events-doc-mistype branch from 57988da to 7bc444d Compare April 27, 2016 10:15

cjihrig commented Apr 27, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell commented Apr 27, 2016

Copy link
Copy Markdown
Member

LGTM
On Apr 27, 2016 3:01 AM, "Сковорода Никита Андреевич" <
notifications@github.com> wrote:

Checklist

  • documentation is changed or added
  • the commit message follows commit guidelines

Affected core subsystem(s)

doc
Description of change

Replace myErr with myEE in one place (that was obviously a mistype).
Fix the expected output to have the actual formatting.

This was overlooked in #5617 #5617
(I also didn't notice that).

/cc @jasnell https://github.com/jasnell

You can view, comment on, or merge this pull request online at:

#6417
Commit Summary

  • doc: Fix EventEmmiter#eventNames() example

File Changes

Patch Links:

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6417

mscdex added the events Issues and PRs related to the events subsystem / EventEmitter. label Apr 27, 2016
mscdex changed the title doc: Fix EventEmmiter#eventNames() example doc: Fix EventEmitter#eventNames() example Apr 27, 2016

mscdex commented Apr 27, 2016

Copy link
Copy Markdown
Contributor

LGTM but commit message still shows 'EventEmmiter'

ChALkeR commented Apr 27, 2016

Copy link
Copy Markdown
Member Author

@mscdex Ah, I didn't notice that, thanks! Will fix that.

ChALkeR force-pushed the fix-events-doc-mistype branch from 7bc444d to 5b5105a Compare April 27, 2016 20:46
ChALkeR changed the title doc: Fix EventEmitter#eventNames() example doc: fix EventEmitter#eventNames() example Apr 27, 2016

ChALkeR commented Apr 27, 2016

Copy link
Copy Markdown
Member Author

@bnoordhuis, @mscdex Fixed.

doc: fix EventEmitter#eventNames() example
10e3efb 
Replace myErr with myEE in one place.
Fix the expected output to have the actual formatting.

PR-URL: nodejs#6417
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
ChALkeR force-pushed the fix-events-doc-mistype branch from 5b5105a to 10e3efb Compare April 27, 2016 20:50

bnoordhuis commented Apr 28, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Apr 30, 2016
doc: fix EventEmitter#eventNames() example
c1f2df9 
Replace myErr with myEE in one place.
Fix the expected output to have the actual formatting.

PR-URL: #6417
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

jasnell commented Apr 30, 2016

Copy link
Copy Markdown
Member

Landed in c1f2df9

jasnell closed this Apr 30, 2016
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
doc: fix EventEmitter#eventNames() example
4068d64 
Replace myErr with myEE in one place.
Fix the expected output to have the actual formatting.

PR-URL: #6417
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
This was referenced May 4, 2016
Closed
Merged
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
doc: fix EventEmitter#eventNames() example
c96df8d 
Replace myErr with myEE in one place.
Fix the expected output to have the actual formatting.

PR-URL: nodejs#6417
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

MylesBorins commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

@ChALkeR lts?

ChALkeR commented Jun 2, 2016

Copy link
Copy Markdown
Member Author

@thealphanerd Perhaps. This is mostly just a typo fix in the docs.

MylesBorins commented Jun 2, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

moved to don't land

@ChALkeR feel free to file a backport PR if you like, it is by no means crucial though

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL