Revert "path: fix win32 normalize false-positive on reserved names" - #64216
Closed
addaleax wants to merge 1 commit into
Closed
Revert "path: fix win32 normalize false-positive on reserved names"#64216addaleax wants to merge 1 commit into
addaleax wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This reverts commit b0a4f16 as it was merged without green Jenkins CI and subsequent builds are broken. Refs: nodejs#64159 Signed-off-by: Anna Henningsen <anna@addaleax.net>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @addaleax. Please 👍 to approve. |
Sorry, something went wrong.
panva
approved these changes
Jun 30, 2026
watilde
approved these changes
Jun 30, 2026
watilde
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you
Sorry, something went wrong.
targos
approved these changes
Jun 30, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
added a commit
that referenced
this pull request
Jun 30, 2026
This reverts commit b0a4f16 as it was merged without green Jenkins CI and subsequent builds are broken. Refs: #64159 Signed-off-by: Anna Henningsen <anna@addaleax.net> PR-URL: #64216 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b0a4f16 as it was merged without green Jenkins CI and subsequent builds are broken.
Refs: #64159