FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

sqlite: fix stale column count in StatementSync.all() by araujogui · Pull Request #64219 · nodejs/node · GitHub

/ node Public

sqlite: fix stale column count in StatementSync.all() - #64219

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
araujogui:sqlite-all-reprepare-num-cols
Jul 7, 2026
ConversationCommits (2)ChecksFiles changed
Merged

sqlite: fix stale column count in StatementSync.all()#64219
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
araujogui:sqlite-all-reprepare-num-cols

Conversation

araujogui commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

If the schema changes after a statement is prepared, SQLite re-prepares it on the next sqlite3_step() call. StatementSync.prototype.all() reads the column count (sqlite3_column_count()) before that step, so on the first call after a schema change the count is stale.

const stmt = db.prepare('SELECT * FROM t'); // 2 columns
db.exec('ALTER TABLE t ADD COLUMN c'); // reprepare pending
stmt.all(); // stale count = 2

const stmt2 = db.prepare('SELECT * FROM t'); // 3 columns
db.exec('ALTER TABLE t DROP COLUMN c'); // reprepare pending
stmt2.all(); // stale count = 3

StatementSync.prototype.get() is unaffected because it reads the count after stepping.

sqlite: read column count after step in StatementSync.all()
70c57f7 
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
Copilot AI review requested due to automatic review settings June 30, 2026 18:02

nodejs-github-bot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

Copilot AI reviewed Jun 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jun 30, 2026
geeksilva97 reviewed Jun 30, 2026
View reviewed changes
Comment thread test/parallel/test-sqlite-statement-sync.js Outdated
geeksilva97 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 30, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 1, 2026

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Jul 1, 2026 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74486/ 💚

araujogui commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@geeksilva97 are we good to land this?

geeksilva97 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

yes

geeksilva97 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Jul 6, 2026
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 6, 2026

nodejs-github-bot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64219
✔  Done loading data for nodejs/node/pull/64219
----------------------------------- PR info ------------------------------------
Title      sqlite: fix stale column count in StatementSync.all() (#64219)
Author     Guilherme Araújo <arauujogui@gmail.com> (@araujogui)
Branch     araujogui:sqlite-all-reprepare-num-cols -> nodejs:main
Labels     c++, author ready, commit-queue-squash, sqlite
Commits    2
 - sqlite: read column count after step in StatementSync.all()
 - sqlite: add schema-change regression tests
Committers 1
 - Guilherme Araújo <arauujogui@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64219
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64219
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 30 Jun 2026 18:02:50 GMT
   ✔  Approvals: 1
   ✔  - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/64219#pullrequestreview-4603550693
   ✘  This PR needs to wait 22 more hours to land (or 0 minutes if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-07-01T11:39:39Z: https://ci.nodejs.org/job/node-test-pull-request/74486/
- Querying data for job/node-test-pull-request/74486/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/28821161836

geeksilva97 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 7, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2026
nodejs-github-bot merged commit 47e332d into nodejs:main Jul 7, 2026
84 checks passed

nodejs-github-bot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Landed in 47e332d

araujogui deleted the sqlite-all-reprepare-num-cols branch July 7, 2026 15:56
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
sqlite: read column count after step in StatementSync.all()
4f232ce 
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #64219
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Jul 21, 2026
Merged
mceachen added a commit to photostructure/node-sqlite that referenced this pull request Jul 26, 2026
chore(sqlite3.c): sync SQLite 3.53.4 and Node.js 68dc114
2db53c4 
SQLite 3.53.4 is a bug-fix release; its SHA3-256 was verified against the
PRODUCT line on sqlite.org before pinning.

The one node_sqlite.cc change upstream (nodejs/node#64219) defers
sqlite3_column_count() until after the first step() in all(). Our port
already resolves column metadata lazily on the first row, so it needed
no equivalent change.
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
sqlite: read column count after step in StatementSync.all()
2d5f445 
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #64219
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
sqlite: read column count after step in StatementSync.all()
c010131 
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #64219
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Aug 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
jasnell jasnell approved these changes
geeksilva97 geeksilva97 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL