FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: allow single-line format when break length is infinite by hamidrezaghavami · Pull Request #64238 · nodejs/node · GitHub

/ node Public

util: allow single-line format when break length is infinite - #64238

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
hamidrezaghavami:fix-inspect-infinity-clean
Aug 24, 2026
ConversationCommits (1)ChecksFiles changed
Merged

util: allow single-line format when break length is infinite#64238
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
hamidrezaghavami:fix-inspect-infinity-clean

Conversation

hamidrezaghavami commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

When calling util.inspect() with a breakLength configuration explicitly set to Infinity, the internal layout formatting logic should bypass multi-line chunking and formatting constraints entirely, allowing the contents to naturally evaluate on a single line.

Currently, isBelowBreakLength goes through a character length loop calculation even when length checks are logically unnecessary due to the infinite upper bound. This change introduces an explicit early return branch within isBelowBreakLength when ctx.breakLength === Infinity, properly enabling a clean, un-wrapped single-line string formatting mode.

Checklist

  • Core internal utility verification

nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jul 1, 2026
MikeMcC399 mentioned this pull request Jul 1, 2026
Merged
ljharb requested changes Jul 2, 2026
View reviewed changes

ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this definitely needs tests to cover the changed behavior. ideally, you'd also provide the tests' output absent this change.

hamidrezaghavami commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Hello, @ljharb The single-line formatting behaviour when breakLength is set to Infinity is covered in a test case that I have provided.
Behaviour of output for context:
Without this modification, if it causes internal length constraint checks, the output is automatically converted to a multi-line format that spans many lines.
With this modification, multi-line chunking is completely avoided by the internal layout logic, which evaluates the contents into a single line format precisely as anticipated:
"a: 1, b: 2, c: 3, d: 4 }"

ljharb reviewed Jul 2, 2026
View reviewed changes
Comment thread test/parallel/test-util-inspect.js Outdated
hamidrezaghavami force-pushed the fix-inspect-infinity-clean branch 6 times, most recently from 038a50a to b91c45e Compare July 5, 2026 21:36
ljharb reviewed Jul 6, 2026
View reviewed changes
Comment thread test/parallel/test-util-inspect.js Outdated
hamidrezaghavami force-pushed the fix-inspect-infinity-clean branch 2 times, most recently from 31523f9 to 3060df3 Compare July 6, 2026 07:06
hamidrezaghavami requested a review from a team as a code owner July 6, 2026 07:06
hamidrezaghavami force-pushed the fix-inspect-infinity-clean branch 3 times, most recently from ede2dd7 to 34da682 Compare July 6, 2026 08:48

hamidrezaghavami commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@ljharb All formatting, linting, and core test suites are now fully passing (29/30 checks successful). The single remaining check (test-macOS) failed on an unrelated debugger timeout (test-debugger-exceptions.js 15000ms exceeded), which appears to be a macOS CI runner flake. Could you please re-run that failed macOS job when you have a moment to review?
Thank you!

ljharb commented Jul 6, 2026

Copy link
Copy Markdown
Member

@hamidrezaghavami again, your test case already passes, so it's not a regression test.

hamidrezaghavami commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@ljharb To clarify my intent: this patch is a performance early exit fast path inside isBelowBreakLength when breakLength === Infinity, avoiding unnecessary string width calculation loops. Because observable output is identical to main, standard tests pass on both branches. Should we label/track this strictly as a performance optimization/cleanup rather than a bug fix?

ljharb commented Jul 6, 2026

Copy link
Copy Markdown
Member

ahh ok, that wasn't clear to me before

ljharb reviewed Jul 6, 2026
View reviewed changes
Comment thread test/parallel/test-util-inspect.js Outdated
hamidrezaghavami force-pushed the fix-inspect-infinity-clean branch from 34da682 to 31719ca Compare July 6, 2026 19:20
util: allow single-line format when break length is infinite
a881d0e 
Signed-off-by: Hamid Reza Ghavami <hamidr.ghavami@gmail.com>
hamidrezaghavami force-pushed the fix-inspect-infinity-clean branch from 31719ca to a881d0e Compare July 6, 2026 20:56

hamidrezaghavami commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@ljharb The CI checks are fully green! I had to force-push one last time to shorten the test string to pass the 80-character max-len linter rule. Could you re-approve when you have a moment, so we can get this merged?
Thank you

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2026

This comment was marked as resolved.

Sign in to view

hamidrezaghavami commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Hey team! Just checking in on this. It looks like it has all necessary approvals, but the checks are failing on some unrelated flaky tests. Could a maintainer please help re-run the CI or let me know if any further action is needed? Thanks!

This comment was marked as outdated.

Sign in to view
trivikr added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 22, 2026

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76345/

trivikr changed the title fix(inspect): allow single-line format when breakLength is Infinity util: allow single-line format when break length is infinite Aug 24, 2026
trivikr added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2026
nodejs-github-bot merged commit f509cf1 into nodejs:main Aug 24, 2026
75 checks passed

nodejs-github-bot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Landed in f509cf1

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
util: allow single-line format when break length is infinite
7f0a207 
Signed-off-by: Hamid Reza Ghavami <hamidr.ghavami@gmail.com>
PR-URL: #64238
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
util: allow single-line format when break length is infinite
cb4b89c 
Signed-off-by: Hamid Reza Ghavami <hamidr.ghavami@gmail.com>
PR-URL: #64238
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 mentioned this pull request Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb approved these changes
juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL