FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: backport 8eda85d from v8 upstream by indutny · Pull Request #6424 · nodejs/node · GitHub

/ node Public

deps: backport 8eda85d from v8 upstream - #6424

Closed
indutny wants to merge 1 commit into
nodejs:masterfrom
indutny:feature/backport-v8-8eda85d54edfa9fec95b22c9afdac0560e72eae1
ConversationCommits (1)ChecksFiles changed
Closed

deps: backport 8eda85d from v8 upstream#6424
indutny wants to merge 1 commit into
nodejs:masterfrom
indutny:feature/backport-v8-8eda85d54edfa9fec95b22c9afdac0560e72eae1

Conversation

indutny commented Apr 27, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

Original commit message:

Postmortem: export DATA_CONSTANT

Useful for inspecting constant fields in objects.

BUG=
R=machenbach

Review-Url: https://codereview.chromium.org/1922903003
Cr-Commit-Position: refs/heads/master@{#35826}

Note: this is really useful for llnode, since EventHandlers
fields are stored as a constant fields in the v6.

cc @nodejs/v8

deps: backport 8eda85d from v8 upstream
3a8c4f9 
Original commit message:

    Postmortem: export DATA_CONSTANT

    Useful for inspecting constant fields in objects.

    BUG=
    R=machenbach

    Review-Url: https://codereview.chromium.org/1922903003
    Cr-Commit-Position: refs/heads/master@{nodejs#35826}

Note: this is really useful for llnode, since `EventHandlers`
fields are stored as a constant fields in the v6.

indutny commented Apr 27, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2409/

mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Apr 27, 2016

bnoordhuis commented Apr 27, 2016

Copy link
Copy Markdown
Member

LGTM, I guess, but can't this be cherry-picked to v5.0 upstream, followed by a wholesale upgrade here?

indutny commented Apr 27, 2016

Copy link
Copy Markdown
Member Author

Yep, sounds like a good plan.

indutny commented Apr 27, 2016

Copy link
Copy Markdown
Member Author

Wait, v8 v5 upstream? I'll ping them about it.

bnoordhuis commented Apr 27, 2016

Copy link
Copy Markdown
Member

The branch is still open, AFAIK, so you should be able to tools/release/merge_to_branch.py it.

jeisinger commented Apr 27, 2016

Copy link
Copy Markdown
Contributor

@natorion manages back-merges to active v8 branches, please sync with him

natorion commented Apr 28, 2016

Copy link
Copy Markdown

Could you please use the process outlined in https://github.com/v8/v8/wiki/Merging%20&%20Patching ? I think Fedor already created a bug?

indutny commented Apr 28, 2016

Copy link
Copy Markdown
Member Author

@natorion yeah, will do it correctly this time. Sorry! 👍

indutny commented May 4, 2016

Copy link
Copy Markdown
Member Author

Should come to use with the next v8 upgrade. cc @ofrobots

ofrobots commented May 4, 2016

Copy link
Copy Markdown
Contributor

Next v8 upgrade contains this: #6572. Once that lands on master, it can be merged to v6.x as well (I can do that).

This issue could be closed; except that it has the lts-watch-4.x tag.

indutny closed this May 4, 2016

indutny commented May 4, 2016

Copy link
Copy Markdown
Member Author

Thank you @ofrobots !

indutny deleted the feature/backport-v8-8eda85d54edfa9fec95b22c9afdac0560e72eae1 branch May 4, 2016 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL