| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Review requested:
|
Sorry, something went wrong.
|
Related failure on Windows build: lld-link : error : undefined symbol: __cpu_model [D:\a\node\node\node_mksnapshot.vcxproj] >>> referenced by D:\a\node\node\deps\histogram\src\hdr_histogram.c:777 >>> histogram.lib(hdr_histogram.obj):(hdr_value_at_percentile) |
Sorry, something went wrong.
|
I was able to reproduce this locally and to fix it with this simple patch. While it can be patched here, landing this fix in the histogram repo is probably better in the long run. |
Sorry, something went wrong.
|
Did you send the patch upstream? Once it’s landed there, we can cherry-pick it here |
Sorry, something went wrong.
|
@StefanStojanovic can you follow up of this and link to the upstream PR? I'm happy to take care of updating this PR but I don't feel comfortable sending your patch upstream |
Sorry, something went wrong.
|
Hey @aduh95, sorry for not doing this earlier. I've opened a PR upstream at HdrHistogram/HdrHistogram_c#142 |
Sorry, something went wrong.
@aduh95 and @StefanStojanovic merged. thank you! |
Sorry, something went wrong.
Sorry, something went wrong.
PR-URL: #64296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original commit message:
Fix ClangCL build on Windows
Refs: HdrHistogram/HdrHistogram_c@62ea52b
PR-URL: #64296
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64296 +/- ##
==========================================
+ Coverage 90.11% 91.87% +1.75%
==========================================
Files 743 382 -361
Lines 242306 170648 -71658
Branches 45618 26102 -19516
==========================================
- Hits 218366 156782 -61584
+ Misses 15445 13566 -1879
+ Partials 8495 300 -8195 see 487 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
PR-URL: #64296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original commit message:
Fix ClangCL build on Windows
Refs: HdrHistogram/HdrHistogram_c@62ea52b
PR-URL: #64296
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #64296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original commit message:
Fix ClangCL build on Windows
Refs: HdrHistogram/HdrHistogram_c@62ea52b
PR-URL: #64296
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
| Back | FazBrowse Home | New Git URL |
This is an automated update of histogram to 0.11.10.