doc: add note about restricted CI to pull-requests.md - #64321
Merged
sxa merged 1 commit intoJul 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
joyeecheung
approved these changes
Jul 7, 2026
jasnell
reviewed
Jul 8, 2026
Comment thread
doc/contributing/pull-requests.md
| to relay the results to you. If a CI has been completed and failed and a | ||
| day or so has passed, it will be worth commenting in the issue to say you | ||
| cannot see what failed and to politely request in the PR that someone gives | ||
| you that information. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I wonder if we could better surface these with automation back to the PR
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Yes that might be feasible but at the moment I feel it's important to have the current state of affairs written down. Maybe cover that in a separate issue?
Sorry, something went wrong.
jasnell
approved these changes
Jul 8, 2026
trivikr
approved these changes
Jul 8, 2026
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
PR-URL: #64321 Signed-off-by: Stewart X Addison <sxa@ibm.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 29, 2026
PR-URL: #64321 Signed-off-by: Stewart X Addison <sxa@ibm.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
PR-URL: #64321 Signed-off-by: Stewart X Addison <sxa@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64318
I did consider referencing the place where this was discussed and the timeframe where it was implemented but as a "current state" with a useful recommendation I think this is probably the right approach.