FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: fix cp symlink and EEXIST handling on Windows by PickBas · Pull Request #64353 · nodejs/node · GitHub

/ node Public

fs: fix cp symlink and EEXIST handling on Windows - #64353

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:issue-59636
Jul 16, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fs: fix cp symlink and EEXIST handling on Windows#64353
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:issue-59636

Conversation

PickBas commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

fs: fix cp symlink and EEXIST handling on Windows

On Windows, fs.cp/fs.cpSync had two bugs:

  • Paths from std::filesystem carried the \\?\ extended-length prefix, breaking path comparison and symlink targets. Now stripped.
  • The EEXIST check used the raw POSIX value, which never matched on Windows. Now compares against std::errc::file_exists.

Re-enables 2 tests that were skipped for this issue.

Fixes: #59636

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jul 8, 2026
fs: fix cp symlink and EEXIST handling on Windows
33b9810 
Fixes: nodejs#59636
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>

codecov Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.24%. Comparing base (e6a8d06) to head (33b9810).
⚠️ Report is 358 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64353      +/-   ##
==========================================
- Coverage   92.01%   90.24%   -1.77%     
==========================================
  Files         379      741     +362     
  Lines      166972   240984   +74012     
  Branches    25554    45398   +19844     
==========================================
+ Hits       153639   217476   +63837     
- Misses      13041    15069    +2028     
- Partials      292     8439    +8147
Files with missing lines Coverage Δ
src/node_file.cc 74.15% <0.00%> (ø)

... and 545 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 14, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 14, 2026

nodejs-github-bot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74806/

nodejs-github-bot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74814/

StefanStojanovic added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 16, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 16, 2026
nodejs-github-bot merged commit 7569219 into nodejs:main Jul 16, 2026
71 checks passed

nodejs-github-bot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Landed in 7569219

aduh95 pushed a commit that referenced this pull request Jul 21, 2026
fs: fix cp symlink and EEXIST handling on Windows
61b5c45 
Fixes: #59636
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>
PR-URL: #64353
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
github-actions Bot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
fs: fix cp symlink and EEXIST handling on Windows
15e18a8 
Fixes: #59636
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>
PR-URL: #64353
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
fs: fix cp symlink and EEXIST handling on Windows
ce113ef 
Fixes: #59636
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>
PR-URL: #64353
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
fs: fix cp symlink and EEXIST handling on Windows
63321ee 
Fixes: #59636
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>
PR-URL: #64353
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
github-actions Bot mentioned this pull request Aug 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
StefanStojanovic StefanStojanovic approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some fs.cp* tests are constantly failing on Windows

4 participants

Back | FazBrowse Home | New Git URL