doc: use promote wording in release guide - #64371
Merged
nodejs-github-bot merged 1 commit intoJul 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
approved these changes
Jul 9, 2026
sxa
approved these changes
Jul 9, 2026
Copy link
Copy Markdown
Member
|
@Muhtasim-Munif-Fahim The checks have failed due to the commit not having a "Signed-off-by" line. Typically this can be done with git commit -s. You may be able to just use git commit --amend -s --no-edit and force push the updated commit to your branch to resolve this. See https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines for the details. |
Sorry, something went wrong.
RafaelGSS
approved these changes
Jul 10, 2026
lpinca
approved these changes
Jul 10, 2026
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64371 ✔ Done loading data for nodejs/node/pull/64371 ----------------------------------- PR info ------------------------------------ Title doc: use promote wording in release guide (#64371) Author Md Muhtasim Munif Fahim <s1911024120@ru.ac.bd> (@Muhtasim-Munif-Fahim, first-time contributor) Branch Muhtasim-Munif-Fahim:codex/node-release-promote-wording -> nodejs:main Labels doc, author ready Commits 1 - doc: use promote wording in release guide Committers 1 - Muhtasim-Munif-Fahim <s1911024120@ru.ac.bd> PR-URL: https://github.com/nodejs/node/pull/64371 Fixes: https://github.com/nodejs/node/issues/64360 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64371 Fixes: https://github.com/nodejs/node/issues/64360 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 08 Jul 2026 19:23:22 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/64371#pullrequestreview-4661336571 ✔ - Stewart X Addison (@sxa): https://github.com/nodejs/node/pull/64371#pullrequestreview-4661926088 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/64371#pullrequestreview-4672321111 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64371#pullrequestreview-4674211599 ✘ 1 GitHub CI job(s) failed: ✘ - lint-commit-message: FAILURE (https://github.com/nodejs/node/actions/runs/28969564469/job/86075940481) ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/29119592853 |
Sorry, something went wrong.
Signed-off-by: Muhtasim-Munif-Fahim <s1911024120@ru.ac.bd>
Muhtasim-Munif-Fahim
force-pushed
the
codex/node-release-promote-wording
branch
from
9718af3 to
8be24eb
Compare
July 11, 2026 21:31
trivikr
approved these changes
Jul 21, 2026
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Muhtasim-Munif-Fahim <s1911024120@ru.ac.bd> PR-URL: #64371 Fixes: #64360 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Muhtasim-Munif-Fahim <s1911024120@ru.ac.bd> PR-URL: #64371 Fixes: #64360 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Muhtasim-Munif-Fahim <s1911024120@ru.ac.bd> PR-URL: #64371 Fixes: #64360 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: Muhtasim-Munif-Fahim <s1911024120@ru.ac.bd> PR-URL: #64371 Fixes: #64360 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: Muhtasim-Munif-Fahim <s1911024120@ru.ac.bd> PR-URL: #64371 Fixes: #64360 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #64360