stream: reject push iterator.throw() with error - #64380
Merged
nodejs-github-bot merged 1 commit intoJul 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Keep the existing consumer cancellation side effects, but reject the iterator.throw() call with the supplied error instead of resolving with done: true. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64380 +/- ##
=======================================
Coverage 90.23% 90.24%
=======================================
Files 741 741
Lines 241194 241194
Branches 45432 45431 -1
=======================================
+ Hits 217640 217663 +23
+ Misses 15129 15089 -40
- Partials 8425 8442 +17
... and 36 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
approved these changes
Jul 9, 2026
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Keep the existing consumer cancellation side effects, but reject the iterator.throw() call with the supplied error instead of resolving with done: true. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #64380 Fixes: #64378 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Keep the existing consumer cancellation side effects, but reject the iterator.throw() call with the supplied error instead of resolving with done: true. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #64380 Fixes: #64378 Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 29, 2026
Keep the existing consumer cancellation side effects, but reject the iterator.throw() call with the supplied error instead of resolving with done: true. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #64380 Fixes: #64378 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Keep the existing consumer cancellation side effects, but reject the iterator.throw() call with the supplied error instead of resolving with done: true. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #64380 Fixes: #64378 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64378
This updates stream/iter push readable iterators so
iterator.throw(error) rejects with the supplied error instead of
resolving with { done: true, value: undefined }.
The existing cancellation behavior is preserved: pending reads, writes,
and drain waiters still observe the consumer error.
Assisted-by: openai:gpt-5.5