FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: fix drop-newest behavior in share() by trivikr · Pull Request #64417 · nodejs/node · GitHub

/ node Public

stream: fix drop-newest behavior in share() - #64417

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
trivikr:stream-iter-share-drop-newest
Jul 21, 2026
ConversationCommits (1)ChecksFiles changed
Merged

stream: fix drop-newest behavior in share()#64417
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
trivikr:stream-iter-share-drop-newest

Conversation

trivikr commented Jul 11, 2026

Copy link
Copy Markdown
Member

Fixes: #64416

Fixes share() with backpressure: 'drop-newest' so upstream pull
results are discarded when the shared buffer reaches highWaterMark.

Previously, #waitForBufferSpace() returned true for drop-newest,
causing the pulled batch to be appended to the full buffer. The buffer
could therefore grow beyond highWaterMark, and stalled consumers
eventually received every batch.

The async implementation now pulls and discards new results while the
buffer is full. The existing test has been updated to verify that the
buffer remains bounded and dropped batches are not delivered.

nodejs-github-bot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Jul 11, 2026
trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 11, 2026

codecov Bot commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.24%. Comparing base (608112a) to head (5fadff0).
⚠️ Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/streams/iter/share.js 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64417      +/-   ##
==========================================
+ Coverage   90.21%   90.24%   +0.03%     
==========================================
  Files         739      739              
  Lines      241650   241650              
  Branches    45542    45551       +9     
==========================================
+ Hits       218013   218086      +73     
+ Misses      15155    15100      -55     
+ Partials     8482     8464      -18
Files with missing lines Coverage Δ
lib/internal/streams/iter/share.js 84.99% <71.42%> (+0.26%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

stream: fix drop-newest behavior in share()
5fadff0 
Discard upstream pull results when the shared buffer has reached its
highWaterMark instead of allowing the buffer to grow beyond its limit.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
trivikr force-pushed the stream-iter-share-drop-newest branch from baae906 to 5fadff0 Compare July 16, 2026 03:48
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2026

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
trivikr added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 20, 2026

nodejs-github-bot commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74930/

trivikr added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2026
nodejs-github-bot merged commit 4991131 into nodejs:main Jul 21, 2026
71 checks passed

nodejs-github-bot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Landed in 4991131

aduh95 pushed a commit that referenced this pull request Jul 21, 2026
stream: fix drop-newest behavior in share()
03abb09 
Discard upstream pull results when the shared buffer has reached its
highWaterMark instead of allowing the buffer to grow beyond its limit.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
PR-URL: #64417
Fixes: #64416
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
stream: fix drop-newest behavior in share()
0418f1a 
Discard upstream pull results when the shared buffer has reached its
highWaterMark instead of allowing the buffer to grow beyond its limit.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
PR-URL: #64417
Fixes: #64416
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
stream: fix drop-newest behavior in share()
ddf7798 
Discard upstream pull results when the shared buffer has reached its
highWaterMark instead of allowing the buffer to grow beyond its limit.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
PR-URL: #64417
Fixes: #64416
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
stream: fix drop-newest behavior in share()
10f3f96 
Discard upstream pull results when the shared buffer has reached its
highWaterMark instead of allowing the buffer to grow beyond its limit.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
PR-URL: #64417
Fixes: #64416
Reviewed-By: James M Snell <jasnell@gmail.com>
trivikr deleted the stream-iter-share-drop-newest branch July 31, 2026 04:31
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
stream: fix drop-newest behavior in share()
d77788e 
Discard upstream pull results when the shared buffer has reached its
highWaterMark instead of allowing the buffer to grow beyond its limit.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
PR-URL: #64417
Fixes: #64416
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Aug 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stream/iter: share() does not discard upstream results with "drop-newest"

3 participants

Back | FazBrowse Home | New Git URL