stream: use RangeError for broadcast overflow - #64420
Merged
nodejs-github-bot merged 1 commit intoJul 24, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
trivikr
force-pushed
the
stream-iter-broadcast-strict-backpressure-overflow
branch
from
46a1376 to
e37419d
Compare
July 11, 2026 07:26
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64420 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.02%
==========================================
Files 741 741
Lines 242158 242158
Branches 45608 45610 +2
==========================================
- Hits 218265 218236 -29
- Misses 15361 15415 +54
+ Partials 8532 8507 -25
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
bjohansebas
approved these changes
Jul 14, 2026
bjohansebas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
jasnell
approved these changes
Jul 19, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
trivikr
marked this pull request as draft
July 22, 2026 05:18
This comment was marked as outdated.
Reject strict-backpressure writes with a RangeError when the broadcast pending writes queue is full. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
trivikr
force-pushed
the
stream-iter-broadcast-strict-backpressure-overflow
branch
from
e37419d to
3926e22
Compare
July 23, 2026 13:02
trivikr
marked this pull request as ready for review
July 23, 2026 13:02
jasnell
approved these changes
Jul 23, 2026
This comment was marked as outdated.
Ethan-Arrowood
approved these changes
Jul 23, 2026
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jul 30, 2026
Reject strict-backpressure writes with a RangeError when the broadcast pending writes queue is full. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #64420 Fixes: #64419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Reject strict-backpressure writes with a RangeError when the broadcast pending writes queue is full. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #64420 Fixes: #64419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64419
Broadcast writers using the strict backpressure policy currently reject
with ERR_INVALID_STATE as a TypeError when the pending writes queue
overflows.
This change uses ERR_INVALID_STATE.RangeError, matching the existing
push writer behavior, and adds regression coverage for the error type and code.