| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Treat null yielded by sync and async stateful transforms as no output, consistent with transform normalization semantics. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
|
Review requested:
|
Sorry, something went wrong.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64462 +/- ##
==========================================
+ Coverage 90.23% 90.67% +0.43%
==========================================
Files 741 744 +3
Lines 241375 245072 +3697
Branches 45483 50711 +5228
==========================================
+ Hits 217800 222207 +4407
+ Misses 15129 14459 -670
+ Partials 8446 8406 -40
... and 105 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
|
I was under the impression that stateful transformers should not be yielding null at all, they should just mark the iterator as done to mark end-of-output? |
Sorry, something went wrong.
A null output is accepted as per specification §9.3 Transforms
And the bug is explained in #64461 @Renegade334 Would you like to create an issue on the specification? I don't see a block from you, but I've removed author-ready. |
Sorry, something went wrong.
Treat null yielded by sync and async stateful transforms as no output, consistent with transform normalization semantics. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #64462 Fixes: #64461 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Treat null yielded by sync and async stateful transforms as no output, consistent with transform normalization semantics. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #64462 Fixes: #64461 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
| Back | FazBrowse Home | New Git URL |
Fixes: #64461
Stateful transforms currently pass null output to the flattening
helpers, causing ERR_INVALID_ARG_TYPE. Transform output
normalization defines null as no output.
Skip null before flattening stateful transform output in both the
sync and async paths.