FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix `socket.readyState` state descriptions by samuel871211 · Pull Request #64468 · nodejs/node · GitHub

/ node Public

doc: fix socket.readyState state descriptions - #64468

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
samuel871211:doc-fix-socket-readystate
Jul 20, 2026
ConversationCommits (1)ChecksFiles changed
Merged

doc: fix socket.readyState state descriptions#64468
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
samuel871211:doc-fix-socket-readystate

Conversation

samuel871211 commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

lib/net.js

ObjectDefineProperty(Socket.prototype, 'readyState', {
  __proto__: null,
  get: function() {
    if (this.connecting) {
      return 'opening';
    } else if (this.readable && this.writable) {
      return 'open';
    } else if (this.readable && !this.writable) {
      return 'readOnly';
    } else if (!this.readable && this.writable) {
      return 'writeOnly';
    }
    return 'closed';
  },
});

nodejs-github-bot commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Jul 13, 2026
bjohansebas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 19, 2026
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 19, 2026

nodejs-github-bot commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64468
✔  Done loading data for nodejs/node/pull/64468
----------------------------------- PR info ------------------------------------
Title      doc: fix `socket.readyState` state descriptions (#64468)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     samuel871211:doc-fix-socket-readystate -> nodejs:main
Labels     doc, net
Commits    1
 - doc: fix socket.readyState state descriptions
Committers 1
 - yusheng <samuel871211@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64468
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64468
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 13 Jul 2026 06:01:27 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64468#pullrequestreview-4698153395
   ✘  This PR needs to wait 10 more hours to land (or 0 minutes if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/29702725892

doc: fix socket.readyState state descriptions
add2851 
Signed-off-by: yusheng <samuel871211@gmail.com>
samuel871211 force-pushed the doc-fix-socket-readystate branch from bf1ad83 to add2851 Compare July 19, 2026 23:53

samuel871211 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@lpinca @bjohansebas
Could you help add the commit-queue tag again ? Tks

bjohansebas added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 20, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 20, 2026
nodejs-github-bot merged commit 1b42f76 into nodejs:main Jul 20, 2026
18 checks passed

nodejs-github-bot commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Landed in 1b42f76

samuel871211 deleted the doc-fix-socket-readystate branch July 21, 2026 00:01
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
doc: fix socket.readyState state descriptions
3aba813 
Signed-off-by: yusheng <samuel871211@gmail.com>
PR-URL: #64468
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
doc: fix socket.readyState state descriptions
738fac2 
Signed-off-by: yusheng <samuel871211@gmail.com>
PR-URL: #64468
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
doc: fix socket.readyState state descriptions
b4a0419 
Signed-off-by: yusheng <samuel871211@gmail.com>
PR-URL: #64468
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
doc: fix socket.readyState state descriptions
ce21e56 
Signed-off-by: yusheng <samuel871211@gmail.com>
PR-URL: #64468
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
doc: fix socket.readyState state descriptions
bced143 
Signed-off-by: yusheng <samuel871211@gmail.com>
PR-URL: #64468
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Aug 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
+1 more reviewer
bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL