stream: remove custom CloneableDOMException implementation - #64469
Merged
nodejs-github-bot merged 1 commit intoJul 22, 2026
Merged
stream: remove custom CloneableDOMException implementation#64469nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #64469 +/- ##
==========================================
- Coverage 90.24% 90.23% -0.01%
==========================================
Files 741 741
Lines 241604 241521 -83
Branches 45526 45523 -3
==========================================
- Hits 218029 217940 -89
- Misses 15107 15114 +7
+ Partials 8468 8467 -1
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
Jul 22, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
aduh95
added a commit
that referenced
this pull request
Jul 30, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #64469 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
added a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #64469 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the comment says, it's more than time to revisit the hack now that DOMException has been clonable for a while