stream: simplify nested PromisePrototypeThens - #64470
Merged
nodejs-github-bot merged 1 commit intoJul 15, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64470 +/- ##
=======================================
Coverage 90.24% 90.25%
=======================================
Files 741 741
Lines 241604 241588 -16
Branches 45526 45536 +10
=======================================
+ Hits 218029 218036 +7
+ Misses 15107 15101 -6
+ Partials 8468 8451 -17
... and 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Renegade334
approved these changes
Jul 13, 2026
Renegade334
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LLGTMTM
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
trivikr
approved these changes
Jul 14, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
added a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #64470 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #64470 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #64470 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
added a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #64470 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to complicate them