events: avoid retaining removed event names - #64475
Merged
nodejs-github-bot merged 1 commit intoJul 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @mcollina. Please 👍 to approve. |
Sorry, something went wrong.
ronag
approved these changes
Jul 13, 2026
jasnell
approved these changes
Jul 13, 2026
Restore shape mode for preallocated EventEmitters while deleting dynamic names from ordinary EventEmitters. Keeping every removed name as an undefined property causes unbounded memory growth when event names are unstructured. Refs: nodejs#64373 Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
fix-event-emitter-unstructured-names
branch
from
f0421ba to
ac80a3b
Compare
July 13, 2026 16:20
ronag
approved these changes
Jul 13, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64475 +/- ##
=======================================
Coverage 90.21% 90.22%
=======================================
Files 741 741
Lines 241608 241615 +7
Branches 45534 45523 -11
=======================================
+ Hits 217972 217987 +15
- Misses 15154 15158 +4
+ Partials 8482 8470 -12
... and 20 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Restore shape mode for preallocated EventEmitters while deleting dynamic names from ordinary EventEmitters. Keeping every removed name as an undefined property causes unbounded memory growth when event names are unstructured. Refs: #64373 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64475 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Restore shape mode for preallocated EventEmitters while deleting dynamic names from ordinary EventEmitters. Keeping every removed name as an undefined property causes unbounded memory growth when event names are unstructured. Refs: #64373 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64475 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 29, 2026
Restore shape mode for preallocated EventEmitters while deleting dynamic names from ordinary EventEmitters. Keeping every removed name as an undefined property causes unbounded memory growth when event names are unstructured. Refs: #64373 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64475 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Restore shape mode for preallocated EventEmitters while deleting dynamic names from ordinary EventEmitters. Keeping every removed name as an undefined property causes unbounded memory growth when event names are unstructured. Refs: #64373 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64475 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #64373.
That change retained removed listener keys with an undefined value for all EventEmitter instances. With unstructured event names, _events would therefore grow without bound.
This restores shape mode so preallocated emitters can retain their fixed keys while ordinary emitters delete dynamic keys or reset the events object. It also adds a regression test that adds and removes 100 unique event names and verifies they are not retained.