quic: preserve session stats after close - #64489
Merged
nodejs-github-bot merged 1 commit intoJul 17, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: manNomi <hanmw110@naver.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
pimterry
approved these changes
Jul 14, 2026
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64489 +/- ##
==========================================
- Coverage 92.01% 90.25% -1.77%
==========================================
Files 381 741 +360
Lines 170167 241688 +71521
Branches 26075 45549 +19474
==========================================
+ Hits 156585 218139 +61554
- Misses 13291 15102 +1811
- Partials 291 8447 +8156
... and 486 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
approved these changes
Jul 15, 2026
bjohansebas
approved these changes
Jul 15, 2026
bjohansebas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: manNomi <hanmw110@naver.com> PR-URL: #64489 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: manNomi <hanmw110@naver.com> PR-URL: #64489 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: manNomi <hanmw110@naver.com> PR-URL: #64489 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: manNomi <hanmw110@naver.com> PR-URL: #64489 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QuicSessionStats[kFinishClose]() used IDX_STATS_STREAM_COUNT when
snapshotting session statistics. Since stream stats contain fewer entries
than session stats, fields beginning with cwnd were omitted after a session
was destroyed and returned undefined.
Use IDX_STATS_SESSION_COUNT so the complete session stats slice is copied
before the native session releases its arena slot. Add regression assertions
for the first previously omitted field (cwnd) and the final session field
(streamsIdleTimedOut).