buffer: handle detached ArrayBuffer views by Archkon · Pull Request #64504 · nodejs/node · GitHub

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (00917ba) to head (acd9bec).
⚠️ Report is 231 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #64504      +/-   ##
==========================================
- Coverage   90.14%   90.13%   -0.01%     
==========================================
  Files         741      741              
  Lines      242076   242051      -25     
  Branches    45558    45543      -15     
==========================================
- Hits       218216   218184      -32     
- Misses      15385    15398      +13     
+ Partials     8475     8469       -6

Files with missing lines	Coverage Δ
src/node_buffer.cc	68.84% <100.00%> (+0.01%)	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

As mentioned in the thread, I'd actually rather we went the other direction to treat detached just as zero-length with these.

Treat detached ArrayBuffers and Buffer or TypedArray views backed by them as zero-length inputs in buffer.isUtf8() and buffer.isAscii(). Both functions now return true for these inputs, consistent with other empty inputs. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

@Archkon ... please keep in mind that folks in the project are volunteers that are often quite busy. Pinging every couple of days for review is a bit rude. An occasional ping once in a while is fine but three pings within a week is excessive.

CI: https://ci.nodejs.org/job/node-test-pull-request/75342/

Landed in 6bab948

Treat detached ArrayBuffers and Buffer or TypedArray views backed by them as zero-length inputs in buffer.isUtf8() and buffer.isAscii(). Both functions now return true for these inputs, consistent with other empty inputs. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64504 Fixes: #64503 Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 14, 2026

jasnell requested changes Jul 15, 2026

View reviewed changes

Archkon force-pushed the viewbuffer branch from 0cc6bf7 to 0261fed Compare July 15, 2026 04:35

Archkon requested a review from jasnell July 15, 2026 04:35