src: fix out-of-bounds write when transcoding odd-length ucs2 - #64512
Merged
nodejs-github-bot merged 1 commit intoAug 22, 2026
Merged
src: fix out-of-bounds write when transcoding odd-length ucs2#64512nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Nashit-h <nashit@bugqore.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64512 +/- ##
==========================================
- Coverage 90.24% 90.23% -0.02%
==========================================
Files 739 739
Lines 241669 241654 -15
Branches 45543 45552 +9
==========================================
- Hits 218087 218049 -38
+ Misses 15150 15134 -16
- Partials 8432 8471 +39
... and 33 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
approved these changes
Jul 19, 2026
Renegade334
approved these changes
Jul 23, 2026
This comment was marked as duplicate.
Copy link
Copy Markdown
Contributor
Author
|
This is approved and green everywhere except the shared-libs Jenkins node, which failed on its own while every sibling job (linked-icu, smallicu, withoutintl, openssl, zlib) passed, so it looks like a flaky run rather than anything from this change. Could someone start a fresh CI so it can land? |
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Nashit-h <nashit@bugqore.com> PR-URL: #64512 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Nashit-h <nashit@bugqore.com> PR-URL: #64512 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CopySourceBuffer sizes its destination for whole UChar units (source_length / sizeof(UChar)) but memcpy's the raw byte length, so Buffer.transcode() of an odd-length utf16le buffer into latin1/ascii writes one byte past the conversion buffer, on both the on-stack and the heap path. Copy only the whole code units so a trailing half byte is ignored; ucnv_fromUChars already consumes length_in_chars units, so the extra byte was never read back. Added an odd-length case to test-icu-transcode.js that trips ASAN on the current code.