test: apply correction to comment - #64524
Merged
nodejs-github-bot merged 1 commit intoJul 18, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The subsequent test checks for an invalid groupAddress, not sourceAddress as the comment say. Adjust the comment to correctly reflect what the test does. Signed-off-by: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
comment-correction
branch
from
1740f70 to
12d33c9
Compare
July 15, 2026 23:26
cjihrig
approved these changes
Jul 16, 2026
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64524 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 739 739
Lines 241639 241639
Branches 45547 45543 -4
==========================================
+ Hits 218031 218057 +26
+ Misses 15152 15117 -35
- Partials 8456 8465 +9 see 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
lpinca
approved these changes
Jul 16, 2026
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64524 ✔ Done loading data for nodejs/node/pull/64524 ----------------------------------- PR info ------------------------------------ Title test: apply correction to comment (#64524) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Trott:comment-correction -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: apply correction to comment Committers 1 - Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/64524 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64524 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 15 Jul 2026 18:10:55 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/64524#pullrequestreview-4714691513 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64524#pullrequestreview-4717438603 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/29604040322 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Can anyone tell me what this means and how I should fix it? I don't need to make my email public in my GitHub profile, do I? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
I think you can ignore the warning. The commit queue failed because this needs a Jenkins CI run. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
The subsequent test checks for an invalid groupAddress, not sourceAddress as the comment say. Adjust the comment to correctly reflect what the test does. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #64524 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
The subsequent test checks for an invalid groupAddress, not sourceAddress as the comment say. Adjust the comment to correctly reflect what the test does. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #64524 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
The subsequent test checks for an invalid groupAddress, not sourceAddress as the comment say. Adjust the comment to correctly reflect what the test does. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #64524 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 29, 2026
The subsequent test checks for an invalid groupAddress, not sourceAddress as the comment say. Adjust the comment to correctly reflect what the test does. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #64524 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
The subsequent test checks for an invalid groupAddress, not sourceAddress as the comment say. Adjust the comment to correctly reflect what the test does. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #64524 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subsequent test checks for an invalid groupAddress, not sourceAddress as the comment say. Adjust the comment to correctly reflect what the test does.