FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

diagnostics_channel: mark TracingChannel as stable by logaretm · Pull Request #64525 · nodejs/node · GitHub

/ node Public

diagnostics_channel: mark TracingChannel as stable - #64525

Closed
logaretm wants to merge 1 commit into
nodejs:mainfrom
logaretm:diagnostics-channel-tracingchannel-stable
ConversationCommits (1)ChecksFiles changed
Closed

diagnostics_channel: mark TracingChannel as stable#64525
logaretm wants to merge 1 commit into
nodejs:mainfrom
logaretm:diagnostics-channel-tracingchannel-stable

Conversation

logaretm commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR Promotes the TracingChannel API (the diagnostics_channel.tracingChannel() factory and the TracingChannel class) from experimental to stable.

TracingChannel has been available since v18.19.0 / v19.9.0 with an unchanged surface, and now has broad real-world adoption: fastify, pino, mysql2, redis, ioredis, mongoose, graphql, h3, srvx, and the Vercel AI SDK publish TracingChannel events natively, and it's consumed by OpenTelemetry, Sentry, Datadog, and New Relic.

IMO, The last behavioral wrinkle in the base API was tracePromise stripping custom thenables (#59936), which was resolved semver-major in #61766 and landed in v26.0

I marked this as stable given the adoption and signals given that the API is stable and backward compatible.

I'm also suggesting we back port this to v26 docs

nodejs-github-bot added diagnostics_channel Issues and PRs related to diagnostics channel doc Issues and PRs related to the documentations. labels Jul 15, 2026
logaretm force-pushed the diagnostics-channel-tracingchannel-stable branch from fa3476f to 5b8df3d Compare July 15, 2026 19:40
logaretm marked this pull request as ready for review July 15, 2026 19:43

bjohansebas commented Jul 15, 2026

Copy link
Copy Markdown
Member

cc: @nodejs/diagnostics

diagnostics_channel: mark TracingChannel as stable
e445b63 
Promotes the diagnostics_channel.tracingChannel() factory and the
TracingChannel class from experimental to stable.

TracingChannel has been available since v18.19.0 / v19.9.0 with an
unchanged surface and now has broad adoption: fastify, pino, mysql2,
redis, ioredis, mongoose, graphql, h3, srvx, and the Vercel AI SDK
publish TracingChannel events natively, and it is consumed by
OpenTelemetry, Sentry, Datadog, and New Relic. The last behavioral
wart, tracePromise stripping custom thenables (nodejs#59936), was resolved
in nodejs#61766.

This mirrors the scoping in nodejs#45290: BoundedChannel, the bindStore /
runStores store helpers, and the concrete built-in channels stay
experimental.

Signed-off-by: Abdelrahman Awad <abdelrahman.awad@sentry.io>
logaretm force-pushed the diagnostics-channel-tracingchannel-stable branch from 5b8df3d to e445b63 Compare July 15, 2026 20:15
RafaelGSS requested a review from Qard July 16, 2026 16:29

bjohansebas commented Aug 9, 2026

Copy link
Copy Markdown
Member

cc: @Qard

bjohansebas added semver-major PRs that contain breaking changes and should be released in the next major version. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 9, 2026

bjohansebas commented Aug 9, 2026

Copy link
Copy Markdown
Member

From what I understand from the Node.js Collaborator Guide, it needs to be released in a major version.

avivkeller added notable-change PRs with changes that should be highlighted in changelogs. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Aug 9, 2026

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @avivkeller.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2026
avivkeller pushed a commit that referenced this pull request Aug 10, 2026
diagnostics_channel: mark TracingChannel as stable
d512d2d 
Promotes the diagnostics_channel.tracingChannel() factory and the
TracingChannel class from experimental to stable.

TracingChannel has been available since v18.19.0 / v19.9.0 with an
unchanged surface and now has broad adoption: fastify, pino, mysql2,
redis, ioredis, mongoose, graphql, h3, srvx, and the Vercel AI SDK
publish TracingChannel events natively, and it is consumed by
OpenTelemetry, Sentry, Datadog, and New Relic. The last behavioral
wart, tracePromise stripping custom thenables (#59936), was resolved
in #61766.

This mirrors the scoping in #45290: BoundedChannel, the bindStore /
runStores store helpers, and the concrete built-in channels stay
experimental.

Signed-off-by: Abdelrahman Awad <abdelrahman.awad@sentry.io>
PR-URL: #64525
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

avivkeller commented Aug 10, 2026

Copy link
Copy Markdown
Member

Landed in d512d2d

avivkeller closed this Aug 10, 2026
cubic-dev-ai Bot mentioned this pull request Aug 10, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
diagnostics_channel: mark TracingChannel as stable
a316b44 
Promotes the diagnostics_channel.tracingChannel() factory and the
TracingChannel class from experimental to stable.

TracingChannel has been available since v18.19.0 / v19.9.0 with an
unchanged surface and now has broad adoption: fastify, pino, mysql2,
redis, ioredis, mongoose, graphql, h3, srvx, and the Vercel AI SDK
publish TracingChannel events natively, and it is consumed by
OpenTelemetry, Sentry, Datadog, and New Relic. The last behavioral
wart, tracePromise stripping custom thenables (#59936), was resolved
in #61766.

This mirrors the scoping in #45290: BoundedChannel, the bindStore /
runStores store helpers, and the concrete built-in channels stay
experimental.

Signed-off-by: Abdelrahman Awad <abdelrahman.awad@sentry.io>
PR-URL: #64525
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
diagnostics_channel: mark TracingChannel as stable
3f4b80e 
Promotes the diagnostics_channel.tracingChannel() factory and the
TracingChannel class from experimental to stable.

TracingChannel has been available since v18.19.0 / v19.9.0 with an
unchanged surface and now has broad adoption: fastify, pino, mysql2,
redis, ioredis, mongoose, graphql, h3, srvx, and the Vercel AI SDK
publish TracingChannel events natively, and it is consumed by
OpenTelemetry, Sentry, Datadog, and New Relic. The last behavioral
wart, tracePromise stripping custom thenables (#59936), was resolved
in #61766.

This mirrors the scoping in #45290: BoundedChannel, the bindStore /
runStores store helpers, and the concrete built-in channels stay
experimental.

Signed-off-by: Abdelrahman Awad <abdelrahman.awad@sentry.io>
PR-URL: #64525
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
github-actions Bot mentioned this pull request Aug 25, 2026
Merged
nodejs-github-bot added a commit that referenced this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current)
2161c94 
Notable changes:

benchmark:
  * (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
  * update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
  * (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
  * mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
  * (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
  * (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
  * (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
  * add basic syntax highlighting (Aviv Keller) #64591
sqlite:
  * (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
  * (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
  * (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
  * (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339

PR-URL: #65551
aduh95 added the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 25, 2026
aduh95 pushed a commit that referenced this pull request Aug 26, 2026
2026-08-26, Version 26.8.0 (Current)
30542c3 
Notable changes:

benchmark:
  * (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
  * update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
  * (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
  * mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
  * (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
  * (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
  * (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
  * add basic syntax highlighting (Aviv Keller) #64591
sqlite:
  * (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
  * (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
  * (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
  * (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339

PR-URL: #65551
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
jasnell jasnell approved these changes
+3 more reviewers
timfish timfish approved these changes
AbhiPrasad AbhiPrasad approved these changes
bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. baking-for-lts PRs that need to wait before landing in a LTS release. commit-queue Add this label to land a pull request using GitHub Actions. diagnostics_channel Issues and PRs related to diagnostics channel doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL