repl: add ImportExpression to disallow list of speculative evaluation - #64534
Closed
BlankParticle wants to merge 1 commit into
Closed
repl: add ImportExpression to disallow list of speculative evaluation#64534BlankParticle wants to merge 1 commit into
BlankParticle wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
REPL speculative completeions were allowing ImportExpression to be egarly evaluated, which caused the REPL to try importing invalid modules which would cause the REPL to get stuck in a loop of trying to import the module and failing causing it to lock up. This commit makes it so that ImportExpression are disallowed from being evaluated in that case. Fixes: nodejs#64523 Signed-off-by: BlankParticle <blankparticle@gmail.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64534 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01%
==========================================
Files 739 739
Lines 241667 241668 +1
Branches 45550 45543 -7
==========================================
- Hits 218093 218090 -3
- Misses 15109 15112 +3
- Partials 8465 8466 +1
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64523
REPL speculative completeions were allowing ImportExpression to be
egarly evaluated, which caused the REPL to try importing invalid modules
which would cause the REPL to get stuck in a loop of trying to import
the module and failing causing it to lock up. This commit makes it so
that ImportExpression are disallowed from being evaluated in that case.