FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

quic: changes for nghttp3_conn_close_stream2 by martenrichter · Pull Request #64574 · nodejs/node · GitHub

/ node Public

quic: changes for nghttp3_conn_close_stream2 - #64574

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
martenrichter:ngclosestream2
Aug 23, 2026
Merged

quic: changes for nghttp3_conn_close_stream2#64574
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
martenrichter:ngclosestream2

Conversation

Copy link
Copy Markdown
Contributor

nghttp2 will introduce a version 2 callback
and function for closing streams.
This prepares node.js for the change.
Other changes may be required for
its full potential.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@pimtery @jasnell Not to be merged now. It is to be prepared when newer nghttp3 arrives in node.js
Also cherry picking on the update PR is possible.

Copy link
Copy Markdown
Contributor Author

Expect building to fail until the update.

Renegade334 marked this pull request as draft July 18, 2026 08:46
Comment thread src/quic/http3.cc Outdated
martenrichter and others added 4 commits August 8, 2026 17:39
nghttp2 will introduce a version 2 callback
and function for closing streams.
This prepares node.js for the change.
Other changes may be required for
 its full potential.

Signed-off-by: Marten Richter <marten.richter@freenet.de>
Co-authored-by: James M Snell <jasnell@gmail.com>
martenrichter marked this pull request as ready for review August 9, 2026 08:48

Copy link
Copy Markdown
Contributor Author

The newer nghttp3 had been merged. Separate from this also ngtcp3 needs an update to address the changes.
It is on my TODO list, but I am chasing again another race condition in sendpendingdata....., so will take a while.

codecov Bot commented Aug 9, 2026
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (e2d7b34) to head (6875095).
⚠️ Report is 267 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64574      +/-   ##
==========================================
- Coverage   90.31%   90.30%   -0.01%     
==========================================
  Files         759      759              
  Lines      248290   248342      +52     
  Branches    46859    46876      +17     
==========================================
+ Hits       224241   224273      +32     
- Misses      15472    15505      +33     
+ Partials     8577     8564      -13     

see 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor Author

I have also added the ngtcp2 change.
It seems we should think perspectively about changing the QuicError interface, since we can have two independent error codes simultaneously on the tx and rx sides. This may be useful for low-level implementation. Though not pressing for this PR.

trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Copy Markdown
Collaborator

trivikr added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 22, 2026
trivikr added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2026
nodejs-github-bot merged commit eae0ca3 into nodejs:main Aug 23, 2026
81 checks passed

Copy link
Copy Markdown
Collaborator

Landed in eae0ca3

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
nghttp2 will introduce a version 2 callback
and function for closing streams.
This prepares node.js for the change.
Other changes may be required for
 its full potential.

Signed-off-by: Marten Richter <marten.richter@freenet.de>
PR-URL: #64574
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
nghttp2 will introduce a version 2 callback
and function for closing streams.
This prepares node.js for the change.
Other changes may be required for
 its full potential.

Signed-off-by: Marten Richter <marten.richter@freenet.de>
PR-URL: #64574
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL