stream: fix unhandled rejection for errored pipeTo writes - #64580
Closed
dushyant-hada-90 wants to merge 1 commit into
Closed
stream: fix unhandled rejection for errored pipeTo writes#64580dushyant-hada-90 wants to merge 1 commit into
dushyant-hada-90 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
markPromiseAsHandled does not cancel V8's unhandled-rejection notification when the write promise is already rejected. Fall back to setPromiseHandled when the destination is no longer writable. Fixes: nodejs#64561 Refs: nodejs#63572 Signed-off-by: dushyant <dushyanthada90@gmail.com>
avivkeller
approved these changes
Jul 20, 2026
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64580 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01%
==========================================
Files 739 739
Lines 241772 241787 +15
Branches 45561 45571 +10
==========================================
- Hits 218194 218192 -2
- Misses 15111 15120 +9
- Partials 8467 8475 +8
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/streams |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Friendly ping @nodejs/streams @nodejs-github-bot |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The issue has been fixed in this PR #64890 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a v26.4.0 regression where ReadableStream.pipeTo() could crash the
process with an unhandled rejection even when the pipeTo() promise
rejection was already caught.
In #63572, per-chunk setPromiseHandled() was replaced with
markPromiseAsHandled(). That is safe for pending write promises, but when
a later chunk is written after the destination has already errored,
writableStreamDefaultWriterWrite() returns an already-rejected promise.
Marking that promise handled afterwards does not cancel V8's pending
unhandled-rejection notification.
This keeps markPromiseAsHandled() on the writable fast path and falls
back to setPromiseHandled() when the destination is no longer writable
(or close is queued/in flight).
No documentation changes; behavior is restored to match Node.js ≤ v26.3.1,
Deno, Bun, and browsers.
Checklist
Fixes: #64561
Refs: #63572