test: resolve flaky repl test - #64594
Closed
avivkeller wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
avivkeller
marked this pull request as draft
July 19, 2026 06:43
Copy link
Copy Markdown
Member
Author
|
Actually, this looks like a bug in V8's replMode: true |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64594 +/- ##
=======================================
Coverage 90.13% 90.14%
=======================================
Files 741 741
Lines 241976 241976
Branches 45543 45551 +8
=======================================
+ Hits 218116 218126 +10
+ Misses 15379 15367 -12
- Partials 8481 8483 +2 see 36 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post 4f844f4 (#64034), there's a small chance that test/parallel/test-repl-user-error-handler.js will fail, since it treats our now asynchronous REPL as synchronous.
Based on the in-progress https://ci.nodejs.org/job/node-stress-single-test/800/, the flake rate is <1.5% (1 failure in 70 runs).