FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix incorrect syntax in examples by evanlucas · Pull Request #6463 · nodejs/node · GitHub

/ node Public

doc: fix incorrect syntax in examples - #6463

Closed
evanlucas wants to merge 1 commit into
nodejs:masterfrom
evanlucas:clusterdoc
Closed

doc: fix incorrect syntax in examples#6463
evanlucas wants to merge 1 commit into
nodejs:masterfrom
evanlucas:clusterdoc

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The cluster docs had a period instead of a semicolon at the end of two
lines.

evanlucas added the doc Issues and PRs related to the documentations. label Apr 29, 2016
Comment thread doc/api/cluster.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

can drop the \' in the middle too

jasnell commented Apr 29, 2016

Copy link
Copy Markdown
Member

LGTM with a nit

The cluster docs had a period instead of a semicolon at the end of two
lines.
mscdex added the cluster Issues and PRs related to the cluster subsystem. label Apr 29, 2016

mscdex commented Apr 29, 2016

Copy link
Copy Markdown
Contributor

LGTM

2 similar comments

Copy link
Copy Markdown
Contributor

LGTM

cjihrig commented Apr 29, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Apr 30, 2016
The cluster docs had a period instead of a semicolon at the end of two
lines.

PR-URL: #6463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell commented Apr 30, 2016

Copy link
Copy Markdown
Member

Landed in 4b0dda0

jasnell closed this Apr 30, 2016
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
The cluster docs had a period instead of a semicolon at the end of two
lines.

PR-URL: #6463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
The cluster docs had a period instead of a semicolon at the end of two
lines.

PR-URL: nodejs#6463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL