doc: clarify rules for adding new built-in modules - #64648
Merged
nodejs-github-bot merged 2 commits intoJul 23, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
panva
approved these changes
Jul 21, 2026
targos
approved these changes
Jul 21, 2026
UlisesGascon
approved these changes
Jul 21, 2026
cjihrig
approved these changes
Jul 21, 2026
marco-ippolito
approved these changes
Jul 21, 2026
lpinca
approved these changes
Jul 21, 2026
Comment thread
doc/contributing/collaborator-guide.md
Outdated
jasnell
approved these changes
Jul 21, 2026
Copy link
Copy Markdown
Member
|
And I'm +1 on retroactively changing the stream/iter to semver-minor. |
Sorry, something went wrong.
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64648 ✔ Done loading data for nodejs/node/pull/64648 ----------------------------------- PR info ------------------------------------ Title doc: clarify rules for adding new built-in modules (#64648) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:introducing-new-modules -> nodejs:main Labels doc, author ready Commits 2 - doc: clarify rules for adding new built-in modules - fixup! doc: clarify rules for adding new built-in modules Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/64648 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64648 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - doc: clarify rules for adding new built-in modules ⚠ - fixup! doc: clarify rules for adding new built-in modules ℹ This PR was created on Tue, 21 Jul 2026 09:41:10 GMT ✔ Approvals: 7 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/64648#pullrequestreview-4743291208 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/64648#pullrequestreview-4743413405 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/64648#pullrequestreview-4743877330 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/64648#pullrequestreview-4745572728 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/64648#pullrequestreview-4745799692 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64648#pullrequestreview-4748687962 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64648#pullrequestreview-4748838761 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/29998782389 |
Sorry, something went wrong.
jakecastelli
approved these changes
Jul 23, 2026
richardlau
approved these changes
Jul 23, 2026
aduh95
added a commit
that referenced
this pull request
Jul 30, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #64648 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95
added a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #64648 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've added the node: prefix requirement to avoid the semver-major requirement for new modules (well I don't remember if it was the intent, but it's definitely the consequence of it). In #62066 (comment), @jasnell marked the PR introducing node:stream/iter as semver-major PRs that contain breaking changes and should be released in the next major version. , but I'd argue that it doesn't make sense to treat as semver-major a new prefixed module (i.e. it cannot shadow a user package) that's behind a runtime flag anyways. EDIT: it's not actually prefix-only, require('stream/iter') === require(node:stream/iter') – but still, because it's opt-in I think my point still stands.
In the case of node:stream/iter, not backporting it is blocking a number of backports on Node.js 24, which cascades into creating more conflicts on unrelated backports, which is a big maintenance burden