doc: remove unsupported syntax from stream_iter.md - #64649
Merged
aduh95 merged 1 commit intoJul 24, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
marco-ippolito
approved these changes
Jul 21, 2026
jasnell
approved these changes
Jul 22, 2026
aymen94
approved these changes
Jul 22, 2026
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64649 ✔ Done loading data for nodejs/node/pull/64649 ----------------------------------- PR info ------------------------------------ Title doc: remove unsupported syntax from `stream_iter.md` (#64649) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:stream_iter-no-ts-syntax -> nodejs:main Labels doc, author ready Commits 2 - doc: remove unsupported syntax from `stream_iter.md` - fixup! doc: remove unsupported syntax from `stream_iter.md` Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/64649 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64649 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 21 Jul 2026 10:26:55 GMT ✔ Approvals: 2 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/64649#pullrequestreview-4744530150 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64649#pullrequestreview-4749903155 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 64649 From https://github.com/nodejs/node * branch refs/pull/64649/merge -> FETCH_HEAD ✔ Fetched commits as 594d0c562c48..53a84be593c0 -------------------------------------------------------------------------------- [main bd643ed512] doc: remove unsupported syntax from `stream_iter.md` Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Tue Jul 21 12:22:45 2026 +0200 1 file changed, 34 insertions(+), 37 deletions(-) Auto-merging doc/type-map.json CONFLICT (content): Merge conflict in doc/type-map.json error: could not apply 53a84be593... fixup! doc: remove unsupported syntax from `stream_iter.md` hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". hint: Disable this message with "git config set advice.mergeConflict false" ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/30001920265 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This will need a rebase |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
FYI in @node-core/doc-kit's web generator (the redesign), we completely support and recommend using this syntax (See: #62045) |
Sorry, something went wrong.
avivkeller
approved these changes
Jul 24, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
stream_iter-no-ts-syntax
branch
from
53a84be to
662ed66
Compare
July 24, 2026 17:39
aduh95
added a commit
that referenced
this pull request
Jul 30, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #64649 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#64649 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Aug 3, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#64649 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our tooling does not deal well with Iterable<Uint8Array> syntax