url: handle unparsable serialized URLs in setters - #64651
Merged
nodejs-github-bot merged 1 commit intoAug 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
mcollina
force-pushed
the
url-handle-unparsable-href-updates
branch
from
0fee8e8 to
985563f
Compare
July 21, 2026 13:19
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #64651 +/- ##
=======================================
Coverage 90.28% 90.29%
=======================================
Files 760 760
Lines 247076 247105 +29
Branches 46594 46593 -1
=======================================
+ Hits 223081 223113 +32
- Misses 15458 15463 +5
+ Partials 8537 8529 -8
... and 29 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
reviewed
Jul 21, 2026
Comment thread
test/parallel/test-whatwg-url-custom-setters.js
jasnell
approved these changes
Jul 21, 2026
mcollina
force-pushed
the
url-handle-unparsable-href-updates
branch
from
985563f to
4024725
Compare
July 25, 2026 08:31
anonrig
approved these changes
Jul 26, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
force-pushed
the
url-handle-unparsable-href-updates
branch
from
4024725 to
48e0076
Compare
August 1, 2026 09:37
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
url-handle-unparsable-href-updates
branch
from
48e0076 to
7f6c2a7
Compare
August 1, 2026 21:49
jasnell
approved these changes
Aug 2, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
panva
approved these changes
Aug 5, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Aug 20, 2026
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
This was referenced Aug 20, 2026
juanarbol
pushed a commit
that referenced
this pull request
Aug 21, 2026
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL updates reparse the stored serialized URL. Return failure when that parse does not succeed so property setters leave the URL unchanged.
Add coverage for URL values that are accepted initially but whose serialized form cannot be parsed again.