doc: fix dnsPromises.lookup verbatim default - #64658
Merged
nodejs-github-bot merged 1 commit intoJul 23, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The verbatim default flipped to true in v17 (nodejs#39987), but the dnsPromises.lookup docs still say false. The order bullet right above it and the dns.lookup section both already say the addresses are not reordered by default, so this bullet was contradicting them. Signed-off-by: BIGSUS24 <152616194+BIGSUS24@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
pimterry
approved these changes
Jul 22, 2026
lpinca
approved these changes
Jul 22, 2026
Ethan-Arrowood
approved these changes
Jul 23, 2026
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @Ethan-Arrowood. Please 👍 to approve. |
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jul 30, 2026
The verbatim default flipped to true in v17 (#39987), but the dnsPromises.lookup docs still say false. The order bullet right above it and the dns.lookup section both already say the addresses are not reordered by default, so this bullet was contradicting them. Signed-off-by: BIGSUS24 <152616194+BIGSUS24@users.noreply.github.com> PR-URL: #64658 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
The verbatim default flipped to true in v17 (#39987), but the dnsPromises.lookup docs still say false. The order bullet right above it and the dns.lookup section both already say the addresses are not reordered by default, so this bullet was contradicting them. Signed-off-by: BIGSUS24 <152616194+BIGSUS24@users.noreply.github.com> PR-URL: #64658 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verbatim option for dnsPromises.lookup() documents its default as false (addresses reordered), but that's stale. The default flipped to true in v17 (#39987), same as the callback dns.lookup().
You can see it contradicts itself already: the order bullet right above says verbatim (addresses are not reordered) by default, and the dns.lookup() section documents the same verbatim option as true. Source confirms it too — both paths start from DNS_ORDER_VERBATIM (lib/dns.js, lib/internal/dns/promises.js), with the global default set to 'verbatim' in lib/internal/dns/utils.js.
This just updates the dnsPromises.lookup() bullet to match. Docs only.