build: add host toolset to perfetto_sdk - #64751
Merged
nodejs-github-bot merged 1 commit intoAug 4, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Signed-off-by: islandryu <shimaryuhei@gmail.com>
islandryu
force-pushed
the
build-perfetto-host-toolset
branch
from
399790c to
ad4369b
Compare
July 26, 2026 05:37
avivkeller
approved these changes
Jul 26, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mertcanaltin
approved these changes
Jul 26, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64751 ✔ Done loading data for nodejs/node/pull/64751 ----------------------------------- PR info ------------------------------------ Title build: add host toolset to perfetto_sdk (#64751) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch islandryu:build-perfetto-host-toolset -> nodejs:main Labels needs-ci, dependencies Commits 1 - build: add host toolset to perfetto_sdk Committers 1 - islandryu <shimaryuhei@gmail.com> PR-URL: https://github.com/nodejs/node/pull/64751 Reviewed-By: Aviv Keller <me@aviv.sh> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64751 Reviewed-By: Aviv Keller <me@aviv.sh> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 26 Jul 2026 05:08:22 GMT ✔ Approvals: 1 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64751#pullrequestreview-4781136782 ✘ This PR needs to wait 73 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-07-29T14:52:12Z: https://ci.nodejs.org/job/node-test-pull-request/75291/ - Querying data for job/node-test-pull-request/75291/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/30513852748 |
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: islandryu <shimaryuhei@gmail.com> PR-URL: #64751 Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: islandryu <shimaryuhei@gmail.com> PR-URL: #64751 Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./configure -C --with-perfetto fails GYP because v8_init#host (mksnapshot) needs perfetto_sdk#host, but perfetto_sdk never declared the host toolset.
Add 'toolsets': ['host', 'target'], matching temporal_capi and libuv.