sea: reject trailing content in config JSON - #64774
Merged
nodejs-github-bot merged 1 commit intoAug 9, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Ensure the on-demand parser reaches the end of the document after reading the root object. Reject concatenated JSON values with TRAILING_CONTENT Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64774 +/- ##
==========================================
- Coverage 90.14% 90.13% -0.01%
==========================================
Files 744 744
Lines 242518 242524 +6
Branches 45685 45698 +13
==========================================
- Hits 218611 218609 -2
- Misses 15396 15432 +36
+ Partials 8511 8483 -28
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
avivkeller
approved these changes
Jul 27, 2026
This comment was marked as spam.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This comment was marked as spam.
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Ensure the on-demand parser reaches the end of the document after reading the root object. Reject concatenated JSON values with TRAILING_CONTENT Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64774 Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Ensure the on-demand parser reaches the end of the document after reading the root object. Reject concatenated JSON values with TRAILING_CONTENT Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64774 Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the on-demand parser reaches the end of the document after reading the root object. Reject concatenated JSON values with TRAILING_CONTENT