FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: expose Windows-only fs open flags by PickBas · Pull Request #64775 · nodejs/node · GitHub

/ node Public

src: expose Windows-only fs open flags - #64775

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:win-new-constants
Aug 7, 2026
Merged

src: expose Windows-only fs open flags#64775
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:win-new-constants

Conversation

PickBas commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

src: expose Windows-only fs open flags

libuv honors several Windows-only open flags but Node never exported the constants, so they were unreachable from fs.open(). Expose UV_FS_O_TEMPORARY, UV_FS_O_SHORT_LIVED, UV_FS_O_SEQUENTIAL and UV_FS_O_RANDOM under the UV_FS_O_ prefix, matching the existing UV_FS_O_FILEMAP. They are 0 on non-Windows platforms.

UV_FS_O_TEMPORARY deletes the file when the last handle closes, UV_FS_O_SHORT_LIVED avoids flushing a throwaway file to disk, and UV_FS_O_SEQUENTIAL/UV_FS_O_RANDOM hint the access pattern to optimize caching.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 27, 2026
PickBas force-pushed the win-new-constants branch from 3fb62df to 23c32f5 Compare July 27, 2026 07:43

codecov Bot commented Jul 27, 2026
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (ee64033) to head (cee62bb).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64775      +/-   ##
==========================================
+ Coverage   90.29%   90.30%   +0.01%     
==========================================
  Files         759      759              
  Lines      247754   247758       +4     
  Branches    46721    46720       -1     
==========================================
+ Hits       223708   223748      +40     
+ Misses      15521    15475      -46     
- Partials     8525     8535      +10     
Files with missing lines Coverage Δ
src/node_constants.cc 99.71% <100.00%> (+<0.01%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2026

Copy link
Copy Markdown
Collaborator

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

Copy link
Copy Markdown
Collaborator

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>
PickBas force-pushed the win-new-constants branch from 23c32f5 to cee62bb Compare August 6, 2026 11:36
StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

StefanStojanovic added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 7, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 7, 2026
nodejs-github-bot merged commit 985aa07 into nodejs:main Aug 7, 2026
71 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 985aa07

aduh95 pushed a commit that referenced this pull request Aug 13, 2026
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>
PR-URL: #64775
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>
PR-URL: #64775
Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL