src: fix heap value deduplication in embedder graph - #64801
Merged
nodejs-github-bot merged 1 commit intoAug 23, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: ishabi <ilyasshabi94@gmail.com>
IlyasShabi
force-pushed
the
ishabi/embedder-graph-deduplication
branch
from
bc8ffc2 to
d62e941
Compare
July 28, 2026 10:09
IlyasShabi
marked this pull request as ready for review
July 28, 2026 10:17
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #64801 +/- ##
==========================================
+ Coverage 90.13% 90.14% +0.01%
==========================================
Files 741 744 +3
Lines 242106 242542 +436
Branches 45551 45692 +141
==========================================
+ Hits 218211 218648 +437
+ Misses 15430 15394 -36
- Partials 8465 8500 +35
... and 93 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
approved these changes
Aug 2, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Aug 12, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: ishabi <ilyasshabi94@gmail.com> PR-URL: #64801 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: ishabi <ilyasshabi94@gmail.com> PR-URL: #64801 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an embedder graph bug introduced by #52295, where distinct V8 values could be treated as the same graph node.
It uses an explicit value lookup for deduplication and extends the internal test binding to expose V8 values for regression testing.