test_runner: fix env option validation - #64865
Merged
nodejs-github-bot merged 1 commit intoAug 4, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: hanityx <hanityx@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64865 +/- ##
=======================================
Coverage 90.14% 90.15%
=======================================
Files 746 746
Lines 242763 242763
Branches 45761 45762 +1
=======================================
+ Hits 218848 218867 +19
+ Misses 15402 15393 -9
+ Partials 8513 8503 -10
... and 29 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
avivkeller
approved these changes
Jul 31, 2026
MoLow
approved these changes
Aug 2, 2026
jasnell
approved these changes
Aug 2, 2026
atlowChemi
approved these changes
Aug 3, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: hanityx <hanityx@gmail.com> PR-URL: #64865 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: hanityx <hanityx@gmail.com> PR-URL: #64865 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid values passed to run({ env }) currently throw
ERR_INTERNAL_ASSERTION because the option name is missing from the
validateObject() call.
This passes options.env to the validator so callers receive
ERR_INVALID_ARG_TYPE instead, and adds a regression test for invalid
values.
Tests: tools/test.py test/parallel/test-runner-run.mjs